Add one more consistency check in AsyncShardFetch (#96553) (#96556)

DaveCTurner · web-flow · commit 8a5bd8a30367 · 2023-06-05T05:49:19.000-04:00
Relates #93632
diff --git a/server/src/main/java/org/elasticsearch/gateway/AsyncShardFetch.java b/server/src/main/java/org/elasticsearch/gateway/AsyncShardFetch.java
@@ -111,6 +111,8 @@ public synchronized FetchResult<T> fetchData(DiscoveryNodes nodes, Set<String> i
             asyncFetch(discoNodesToFetch, fetchingRound);
         }
 
+        assert assertFetchingCountConsistent();
+
         // if we are still fetching, return null to indicate it
         if (hasAnyNodeFetching()) {
             return new FetchResult<>(shardId, null, emptySet());

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,8 @@ public synchronized FetchResult<T> fetchData(DiscoveryNodes nodes, Set<String> i`
`111`	`111`	`asyncFetch(discoNodesToFetch, fetchingRound);`
`112`	`112`	`}`
`113`	`113`
	`114`	`+ assert assertFetchingCountConsistent();`
	`115`	`+`
`114`	`116`	`// if we are still fetching, return null to indicate it`
`115`	`117`	`if (hasAnyNodeFetching()) {`
`116`	`118`	`return new FetchResult<>(shardId, null, emptySet());`