using else-if instead of if, to avoid calling onFailure twice

masseyke · masseyke · commit 8b3a44246a07 · 2025-02-03T16:54:00.000-06:00
diff --git a/x-pack/plugin/migrate/src/main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamIndexTransportAction.java b/x-pack/plugin/migrate/src/main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamIndexTransportAction.java
@@ -290,7 +290,7 @@ void reindex(String sourceIndexName, String destIndexName, ActionListener<BulkBy
                     )
                 );
             }
-            if (bulkByScrollResponse.getBulkFailures().isEmpty() == false) {
+            else if (bulkByScrollResponse.getBulkFailures().isEmpty() == false) {
                 BulkItemResponse.Failure firstBulkFailure = bulkByScrollResponse.getBulkFailures().get(0);
                 listener.onFailure(
                     new ElasticsearchException(

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ void reindex(String sourceIndexName, String destIndexName, ActionListener<BulkBy`
`290`	`290`	`)`
`291`	`291`	`);`
`292`	`292`	`}`
`293`		`- if (bulkByScrollResponse.getBulkFailures().isEmpty() == false) {`
	`293`	`+ else if (bulkByScrollResponse.getBulkFailures().isEmpty() == false) {`
`294`	`294`	`BulkItemResponse.Failure firstBulkFailure = bulkByScrollResponse.getBulkFailures().get(0);`
`295`	`295`	`listener.onFailure(`
`296`	`296`	`new ElasticsearchException(`