iter comments

Author: martijnvg

server/src/main/java/org/elasticsearch/index/codec/TrackingPostingsInMemoryBytesCodec.java

@@ -70,8 +70,8 @@ static final class TrackingLengthFieldsConsumer extends FieldsConsumer {
             this.state = state;
             this.in = in;
             this.totalBytes = new long[1];
-            // Alternatively, we can consider using a FixedBitSet here and size to max(fieldNumber). T
-            // his should be faster without worrying too much about memory usage.
+            // Alternatively, we can consider using a FixedBitSet here and size to max(fieldNumber).
+            // This should be faster without worrying too much about memory usage.
             this.seenFields = new IntHashSet(state.fieldInfos.size());
         }
 
@@ -110,7 +110,8 @@ public Terms terms(String field) throws IOException {
                 return new TrackingLengthTerms(terms, bytes -> totalBytes[0] += bytes);
             } else {
                 // As far as I know only when bloom filter for _id filter gets written this method gets invoked twice for the same field.
-                // So maybe we can get rid of the seenFields here? And just keep track of whether _id field has been seen?
+                // So maybe we can get rid of the seenFields here? And just keep track of whether _id field has been seen? However, this
+                // is fragile and could make us vulnerable to tricky bugs in the future if this is no longer the case.
                 return terms;
             }
         }