Fix security tests

Author: alexey-ivanov-es

server/src/internalClusterTest/java/org/elasticsearch/search/fieldcaps/FieldCapabilitiesIT.java

@@ -102,6 +102,7 @@
 import static org.hamcrest.Matchers.greaterThanOrEqualTo;
 import static org.hamcrest.Matchers.hasKey;
 import static org.hamcrest.Matchers.hasSize;
+import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
 import static org.hamcrest.Matchers.nullValue;
 
@@ -913,6 +914,13 @@ public void testIndexMode() throws Exception {
         assertThat(actualIndexModes, equalTo(indexModes));
     }
 
+    public void testNoneExpressionIndices() {
+        // The auth code injects the pattern ["*", "-*"] which effectively means a request that requests no indices
+        FieldCapabilitiesResponse response = client().prepareFieldCaps("*", "-*").setFields("*").get();
+
+        assertThat(response.getIndices().length, is(0));
+    }
+
     private void assertIndices(FieldCapabilitiesResponse response, String... indices) {
         assertNotNull(response.getIndices());
         Arrays.sort(indices);

server/src/main/java/org/elasticsearch/action/fieldcaps/TransportFieldCapabilitiesAction.java

@@ -165,7 +165,7 @@ private void doExecuteForked(Task task, FieldCapabilitiesRequest request, Action
             if (localIndexNames.length == 0) {
                 String[] concreteIndexNames = indexNameExpressionResolver.concreteIndexNames(projectMetadata, indicesOptions);
                 resolvedLocallyList.add(createResolvedIndexExpression(Metadata.ALL, concreteIndexNames));
-            } else {
+            }  else if (IndexNameExpressionResolver.isNoneExpression(localIndexNames) == false) {
                 for (String localIndexName : localIndexNames) {
                     String[] concreteIndexNames = indexNameExpressionResolver.concreteIndexNames(
                         projectMetadata,