cleanup

Author: richard-dennehy

x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/authn/SamlAuthnRequestValidator.java

@@ -250,7 +250,7 @@ private static void validateNameIdPolicy(AuthnRequest request, SamlServiceProvid
     }
 
     private boolean validateSignature(ParsedQueryString queryString, Collection<X509Credential> credentials) {
-        final String javaSigAlgorithm = SamlFactory.getJavaAlorithmNameFromUri(queryString.sigAlg);
+        final String javaSigAlgorithm = SamlFactory.getJavaAlgorithmNameFromUri(queryString.sigAlg);
         final byte[] contentBytes = queryString.reconstructQueryParameters().getBytes(StandardCharsets.UTF_8);
         final byte[] signatureBytes = Base64.getDecoder().decode(queryString.signature);
         return credentials.stream().anyMatch(credential -> {

x-pack/plugin/identity-provider/src/main/java/org/elasticsearch/xpack/idp/saml/support/SamlFactory.java

@@ -11,7 +11,6 @@
 import org.elasticsearch.ElasticsearchSecurityException;
 import org.elasticsearch.common.Strings;
 import org.elasticsearch.common.hash.MessageDigests;
-import org.elasticsearch.core.SuppressForbidden;
 import org.elasticsearch.core.XmlUtils;
 import org.opensaml.core.xml.XMLObject;
 import org.opensaml.core.xml.XMLObjectBuilderFactory;
@@ -217,12 +216,11 @@ public static Element toDomElement(XMLObject object) {
      *
      * @throws ParserConfigurationException if one of the features can't be set on the DocumentBuilderFactory
      */
-    @SuppressForbidden(reason = "This is the only allowed way to construct a DocumentBuilder")
     public static DocumentBuilder getHardenedBuilder(String[] schemaFiles) throws ParserConfigurationException {
         return XmlUtils.getHardenedBuilder(resolveSchemaFilePaths(schemaFiles));
     }
 
-    public static String getJavaAlorithmNameFromUri(String sigAlg) {
+    public static String getJavaAlgorithmNameFromUri(String sigAlg) {
         return switch (sigAlg) {
             case "http://www.w3.org/2000/09/xmldsig#dsa-sha1" -> "SHA1withDSA";
             case "http://www.w3.org/2000/09/xmldsig#dsa-sha256" -> "SHA256withDSA";