Skip to content

Commit 8ebf21e

Browse files
committed
add comments
1 parent 83df3da commit 8ebf21e

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/blockhash/CategorizeBlockHashTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ public void testCategorize_withDriver() {
290290
BytesRefVector.Builder textsBuilder = driverContext.blockFactory().newBytesRefVectorBuilder(10);
291291
LongVector.Builder countsBuilder = driverContext.blockFactory().newLongVectorBuilder(10)
292292
) {
293+
// Note that just using "a" or "aaa" doesn't work, because the ml_standard
294+
// tokenizer drops numbers, including hexadecimal ones.
293295
textsBuilder.appendBytesRef(new BytesRef("aaazz"));
294296
textsBuilder.appendBytesRef(new BytesRef("bbbzz"));
295297
textsBuilder.appendBytesRef(new BytesRef("words words words goodbye jan"));

x-pack/plugin/esql/qa/testFixtures/src/main/resources/categorize.csv-spec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,9 @@ COUNT():long | category:keyword
247247
5 | .*?Kubernetes.+?cluster.*?
248248
2 | .*?servers.*?
249249
1 | null
250+
251+
// Note: DB is removed from "DB servers", because the ml_standard
252+
// tokenizer drops numbers, including hexadecimal ones.
250253
;
251254

252255
on TO_UPPER

0 commit comments

Comments
 (0)