Skip to content

Commit 90349ff

Browse files
committed
Trim to size lists created in source fetchers
1 parent ec846f7 commit 90349ff

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

server/src/main/java/org/elasticsearch/index/mapper/ArraySourceValueFetcher.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public ArraySourceValueFetcher(Set<String> sourcePaths, Object nullValue) {
5656

5757
@Override
5858
public List<Object> fetchValues(Source source, int doc, List<Object> ignoredValues) {
59-
List<Object> values = new ArrayList<>();
59+
ArrayList<Object> values = new ArrayList<>();
6060
for (String path : sourcePaths) {
6161
Object sourceValue = source.extractValue(path, nullValue);
6262
if (sourceValue == null) {
@@ -70,6 +70,7 @@ public List<Object> fetchValues(Source source, int doc, List<Object> ignoredValu
7070
ignoredValues.add(sourceValue);
7171
}
7272
}
73+
values.trimToSize();
7374
return values;
7475
}
7576

server/src/main/java/org/elasticsearch/index/mapper/SourceValueFetcher.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public SourceValueFetcher(Set<String> sourcePaths, Object nullValue) {
5555

5656
@Override
5757
public List<Object> fetchValues(Source source, int doc, List<Object> ignoredValues) {
58-
List<Object> values = new ArrayList<>();
58+
ArrayList<Object> values = new ArrayList<>();
5959
for (String path : sourcePaths) {
6060
Object sourceValue = source.extractValue(path, nullValue);
6161
if (sourceValue == null) {
@@ -92,6 +92,7 @@ public List<Object> fetchValues(Source source, int doc, List<Object> ignoredValu
9292
}
9393
}
9494
}
95+
values.trimToSize();
9596
return values;
9697
}
9798

0 commit comments

Comments
 (0)