comments

Author: ywangd

modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3ClientsManager.java

@@ -312,7 +312,7 @@ final AmazonS3Reference client(RepositoryMetadata repositoryMetadata) {
                     return existing;
                 }
                 if (closed.get()) {
-                    // Not adding a new client once the manager is closed since there won't be anything to close it
+                    // Not adding a new client once the clients holder is closed since there won't be anything to close it
                     throw new IllegalStateException("Project [" + projectId() + "] clients holder is closed");
                 }
                 if (managerClosed.get()) {
@@ -321,15 +321,15 @@ final AmazonS3Reference client(RepositoryMetadata repositoryMetadata) {
                     throw new IllegalStateException("s3 clients manager is closed");
                 }
                 // The close() method maybe called after we checked it, it is ok since we are already inside the synchronized block.
-                // The clearCache() will clear the newly added client.
+                // The close method calls clearCache() which will clear the newly added client.
                 final var newClientReference = clientBuilder.apply(settings);
                 clientsCache = Maps.copyMapWithAddedEntry(clientsCache, clientKey, newClientReference);
                 return newClientReference;
             }
         }
 
         /**
-         * Clear the cache by closing and clear out all clients. Subsequent {@link #client(RepositoryMetadata)} calls will recreate
+         * Clear the cache by closing and clearing out all clients. Subsequent {@link #client(RepositoryMetadata)} calls will recreate
          * the clients and populate the cache again.
          */
         final synchronized void clearCache() {