Skip to content

Commit 90e2a95

Browse files
committed
Remove transport version checks for task settings class
1 parent b10aed9 commit 90e2a95

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/completion/GoogleVertexAiChatCompletionTaskSettings.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,7 @@ public GoogleVertexAiChatCompletionTaskSettings(ThinkingConfig thinkingConfig) {
3838
}
3939

4040
public GoogleVertexAiChatCompletionTaskSettings(StreamInput in) throws IOException {
41-
if (in.getTransportVersion().onOrAfter(TransportVersions.GEMINI_THINKING_BUDGET_ADDED)) {
42-
thinkingConfig = new ThinkingConfig(in);
43-
} else {
44-
thinkingConfig = EMPTY_THINKING_CONFIG;
45-
}
41+
thinkingConfig = new ThinkingConfig(in);
4642
}
4743

4844
public static GoogleVertexAiChatCompletionTaskSettings fromMap(Map<String, Object> taskSettings) {
@@ -97,9 +93,7 @@ public TransportVersion getMinimalSupportedVersion() {
9793

9894
@Override
9995
public void writeTo(StreamOutput out) throws IOException {
100-
if (out.getTransportVersion().onOrAfter(TransportVersions.GEMINI_THINKING_BUDGET_ADDED)) {
101-
thinkingConfig.writeTo(out);
102-
}
96+
thinkingConfig.writeTo(out);
10397
}
10498

10599
@Override

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/completion/GoogleVertexAiChatCompletionTaskSettingsTests.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
package org.elasticsearch.xpack.inference.services.googlevertexai.completion;
99

10-
import org.elasticsearch.TransportVersion;
11-
import org.elasticsearch.TransportVersions;
1210
import org.elasticsearch.common.ValidationException;
1311
import org.elasticsearch.common.io.stream.Writeable;
1412
import org.elasticsearch.xpack.inference.services.InferenceSettingsTestCase;
@@ -87,18 +85,6 @@ public void testOf_doesNotOverrideOriginalSettings_whenNewSettingsNotPresent() {
8785
assertThat(updatedSettings.thinkingConfig().getThinkingBudget(), is(originalThinkingBudget));
8886
}
8987

90-
@Override
91-
protected GoogleVertexAiChatCompletionTaskSettings mutateInstanceForVersion(
92-
GoogleVertexAiChatCompletionTaskSettings instance,
93-
TransportVersion version
94-
) {
95-
if (version.before(TransportVersions.GEMINI_THINKING_BUDGET_ADDED)) {
96-
return new GoogleVertexAiChatCompletionTaskSettings();
97-
} else {
98-
return instance;
99-
}
100-
}
101-
10288
@Override
10389
protected GoogleVertexAiChatCompletionTaskSettings fromMutableMap(Map<String, Object> mutableMap) {
10490
return GoogleVertexAiChatCompletionTaskSettings.fromMap(mutableMap);

0 commit comments

Comments
 (0)