Skip to content

Commit 90f66ad

Browse files
ES|QL: fix generative tests (#131071) (#132435)
excluding dense vector fields for now, since they are not supported by most commands (cherry picked from commit 0b06d9f) # Conflicts: # muted-tests.yml Co-authored-by: Luigi Dell'Aquila <[email protected]>
1 parent 90daf4a commit 90f66ad

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

muted-tests.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -395,14 +395,8 @@ tests:
395395
- class: org.elasticsearch.cluster.metadata.ComposableIndexTemplateTests
396396
method: testMergeEmptyMappingsIntoTemplateWithNonEmptySettings
397397
issue: https://github.com/elastic/elasticsearch/issues/130050
398-
- class: org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT
399-
method: test
400-
issue: https://github.com/elastic/elasticsearch/issues/130067
401398
- class: geoip.GeoIpMultiProjectIT
402399
issue: https://github.com/elastic/elasticsearch/issues/130073
403-
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
404-
method: test
405-
issue: https://github.com/elastic/elasticsearch/issues/130067
406400
- class: org.elasticsearch.search.SearchWithRejectionsIT
407401
method: testOpenContextsAfterRejections
408402
issue: https://github.com/elastic/elasticsearch/issues/130821

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/EsqlQueryGenerator.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,9 @@ public static boolean fieldCanBeUsed(Column field) {
288288
// https://github.com/elastic/elasticsearch/issues/121741
289289
field.name().equals("<all-fields-projected>")
290290
// this is a known pathological case, no need to test it for now
291-
|| field.name().equals("<no-fields>")) == false;
291+
|| field.name().equals("<no-fields>")
292+
// no dense vectors for now, they are not supported in most commands
293+
|| field.type().contains("vector")) == false;
292294
}
293295

294296
public static String unquote(String colName) {

0 commit comments

Comments
 (0)