Make DecayTests more robust using closeTo(..., Math.ulp(...)) instead of equalTo (to work with rounded values)

Author: timgrein

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/score/DecayTests.java

@@ -625,7 +625,7 @@ private static List<TestCaseSupplier> intTestCase(
                     ),
                     startsWith("DecayIntEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -659,7 +659,7 @@ private static List<TestCaseSupplier> intRandomTestCases() {
                 ),
                 startsWith("DecayIntEvaluator["),
                 DataType.DOUBLE,
-                equalTo(scoreScriptNumericResult)
+                closeTo(scoreScriptNumericResult, Math.ulp(scoreScriptNumericResult))
             );
         }));
     }
@@ -699,7 +699,7 @@ private static List<TestCaseSupplier> longTestCase(
                     ),
                     startsWith("DecayLongEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -769,7 +769,7 @@ private static List<TestCaseSupplier> doubleTestCase(
                     ),
                     startsWith("DecayDoubleEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -803,7 +803,7 @@ private static List<TestCaseSupplier> doubleRandomTestCases() {
                 ),
                 startsWith("DecayDoubleEvaluator["),
                 DataType.DOUBLE,
-                equalTo(scoreScriptNumericResult)
+                closeTo(scoreScriptNumericResult, Math.ulp(scoreScriptNumericResult))
             );
         }));
     }
@@ -839,7 +839,7 @@ private static List<TestCaseSupplier> geoPointTestCase(
                     ),
                     startsWith("DecayGeoPointEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -867,7 +867,7 @@ private static List<TestCaseSupplier> geoPointTestCaseKeywordScale(
                     ),
                     startsWith("DecayGeoPointEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -901,7 +901,7 @@ private static List<TestCaseSupplier> geoPointRandomTestCases() {
                 ),
                 startsWith("DecayGeoPointEvaluator["),
                 DataType.DOUBLE,
-                equalTo(scoreScriptNumericResult)
+                closeTo(scoreScriptNumericResult, Math.ulp(scoreScriptNumericResult))
             );
         }));
     }
@@ -981,7 +981,7 @@ private static List<TestCaseSupplier> geoPointOffsetKeywordTestCase(
                     ),
                     startsWith("DecayGeoPointEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -1009,7 +1009,7 @@ private static List<TestCaseSupplier> cartesianPointTestCase(
                     ),
                     startsWith("DecayCartesianPointEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 )
             )
         );
@@ -1037,7 +1037,7 @@ private static List<TestCaseSupplier> datetimeTestCase(
                     ),
                     startsWith("DecayDatetimeEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 ).withoutEvaluator()
             )
         );
@@ -1080,7 +1080,7 @@ private static List<TestCaseSupplier> datetimeRandomTestCases() {
                 ),
                 startsWith("DecayDatetimeEvaluator["),
                 DataType.DOUBLE,
-                equalTo(scoreScriptNumericResult)
+                closeTo(scoreScriptNumericResult, Math.ulp(scoreScriptNumericResult))
             );
         }));
     }
@@ -1122,7 +1122,7 @@ private static List<TestCaseSupplier> dateNanosTestCase(
                     ),
                     startsWith("DecayDateNanosEvaluator["),
                     DataType.DOUBLE,
-                    equalTo(expected)
+                    closeTo(expected, Math.ulp(expected))
                 ).withoutEvaluator()
             )
         );