Skip to content

Commit 93f1857

Browse files
committed
Fixes after merge
1 parent 0ca9a89 commit 93f1857

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

x-pack/plugin/otel-data/src/javaRestTest/java/org/elasticsearch/action/otlp/OTLPMetricsIndexingRestIT.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public class OTLPMetricsIndexingRestIT extends ESRestTestCase {
7171
.user(USER, PASS, "superuser", false)
7272
.setting("xpack.security.autoconfiguration.enabled", "false")
7373
.setting("xpack.license.self_generated.type", "trial")
74-
.setting("xpack.security.enabled", "false")
74+
.setting("xpack.ml.enabled", "false")
7575
.setting("xpack.watcher.enabled", "false")
7676
.build();
7777

@@ -117,7 +117,7 @@ public void tearDown() throws Exception {
117117

118118
public void testIngestMetricViaMeterProvider() throws Exception {
119119
Meter sampleMeter = meterProvider.get("io.opentelemetry.example.metrics");
120-
long totalMemory = randomLong();
120+
long totalMemory = 42;
121121

122122
sampleMeter.gaugeBuilder("jvm.memory.total")
123123
.setDescription("Reports JVM memory usage.")
@@ -135,15 +135,14 @@ public void testIngestMetricViaMeterProvider() throws Exception {
135135
assertThat(ObjectPath.evaluate(source, "@timestamp"), isA(String.class));
136136
assertThat(ObjectPath.evaluate(source, "start_timestamp"), isA(String.class));
137137
assertThat(ObjectPath.evaluate(source, "_metric_names_hash"), isA(String.class));
138-
assertThat(ObjectPath.evaluate(source, "metrics.jvm\\.memory\\.total").toString(), equalTo(Long.toString(totalMemory)));
138+
assertThat(ObjectPath.<Number>evaluate(source, "metrics.jvm\\.memory\\.total").longValue(), equalTo(totalMemory));
139139
assertThat(ObjectPath.evaluate(source, "unit"), equalTo("By"));
140-
assertThat(ObjectPath.evaluate(source, "resource.attributes.service\\.name"), equalTo("elasticsearch"));
141140
assertThat(ObjectPath.evaluate(source, "scope.name"), equalTo("io.opentelemetry.example.metrics"));
142141
}
143142

144143
public void testIngestMetricDataViaMetricExporter() throws Exception {
145144
long now = Clock.getDefault().now();
146-
long totalMemory = randomLong();
145+
long totalMemory = 42;
147146
MetricData jvmMemoryMetricData = createLongGauge(TEST_RESOURCE, Attributes.empty(), "jvm.memory.total", totalMemory, "By", now);
148147

149148
export(List.of(jvmMemoryMetricData));
@@ -153,7 +152,7 @@ public void testIngestMetricDataViaMetricExporter() throws Exception {
153152
assertThat(ObjectPath.evaluate(source, "@timestamp"), equalTo(timestampAsString(now)));
154153
assertThat(ObjectPath.evaluate(source, "start_timestamp"), equalTo(timestampAsString(now)));
155154
assertThat(ObjectPath.evaluate(source, "_metric_names_hash"), isA(String.class));
156-
assertThat(ObjectPath.evaluate(source, "metrics.jvm\\.memory\\.total").toString(), equalTo(Long.toString(totalMemory)));
155+
assertThat(ObjectPath.<Number>evaluate(source, "metrics.jvm\\.memory\\.total").longValue(), equalTo(totalMemory));
157156
assertThat(ObjectPath.evaluate(source, "unit"), equalTo("By"));
158157
assertThat(ObjectPath.evaluate(source, "resource.attributes.service\\.name"), equalTo("elasticsearch"));
159158
assertThat(ObjectPath.evaluate(source, "scope.name"), equalTo("io.opentelemetry.example.metrics"));

x-pack/plugin/otel-data/src/main/java/org/elasticsearch/xpack/oteldata/otlp/OTLPMetricsTransportAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ private void addIndexRequest(
127127
try (XContentBuilder xContentBuilder = XContentFactory.cborBuilder(new BytesStreamOutput())) {
128128
var dynamicTemplates = metricDocumentBuilder.buildMetricDocument(xContentBuilder, dataPointGroup);
129129
bulkRequestBuilder.add(
130-
new IndexRequest(dataPointGroup.targetIndex().index()).opType(DocWriteRequest.OpType.CREATE)
130+
new IndexRequest(dataPointGroup.targetIndex()).opType(DocWriteRequest.OpType.CREATE)
131131
.setRequireDataStream(true)
132132
.source(xContentBuilder)
133133
// TODO uncomment after https://github.com/elastic/elasticsearch/pull/132566 has been merged

0 commit comments

Comments
 (0)