Address review comments

Author: alexey-ivanov-es

server/src/main/java/org/elasticsearch/cluster/metadata/ProjectMetadata.java

@@ -1539,11 +1539,7 @@ public Builder removeReservedState(ReservedStateMetadata metadata) {
             return this;
         }
 
-        public Settings settings() {
-            return this.settings;
-        }
-
-        public ProjectMetadata.Builder settings(Settings settings) {
+        public Builder settings(Settings settings) {
             this.settings = settings;
             return this;
         }

server/src/main/java/org/elasticsearch/common/settings/SettingsUpdater.java

@@ -150,10 +150,10 @@ public synchronized ProjectMetadata updateProjectSettings(
         // validate that settings and their values are correct
         scopedSettings.validate(finalSettings, true);
 
-        ProjectMetadata.Builder result = ProjectMetadata.builder(projectMetadata)
-            .settings(Settings.builder().put(finalSettings).put(unknownOrInvalidSettings).build());
+        Settings resultSettings = Settings.builder().put(finalSettings).put(unknownOrInvalidSettings).build();
+        ProjectMetadata.Builder result = ProjectMetadata.builder(projectMetadata).settings(resultSettings);
         // validate that SettingsUpdaters can be applied without errors
-        scopedSettings.validateUpdate(result.settings());
+        scopedSettings.validateUpdate(resultSettings);
 
         return result.build();
     }