Skip to content

Commit 973ab5f

Browse files
committed
better fix
1 parent 263744a commit 973ab5f

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlMemoryAutoscalingCapacity.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ public static Builder builder(ByteSizeValue nodeSize, ByteSizeValue tierSize) {
1717
}
1818

1919
public static Builder from(AutoscalingCapacity autoscalingCapacity) {
20-
return builder(autoscalingCapacity.node().memory(), autoscalingCapacity.total().memory());
20+
if (autoscalingCapacity == null) {
21+
return builder(null, null);
22+
} else {
23+
return builder(autoscalingCapacity.node().memory(), autoscalingCapacity.total().memory());
24+
}
2125
}
2226

2327
@Override

x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlMemoryAutoscalingDecider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ public MlMemoryAutoscalingCapacity scale(
259259
.map(result -> {
260260
MlMemoryAutoscalingCapacity capacity = ensureScaleDown(
261261
result,
262-
context.currentCapacity() == null ? null : MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build()
262+
MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build()
263263
);
264264
if (capacity == null) {
265265
return null;
@@ -809,7 +809,7 @@ static MlMemoryAutoscalingCapacity ensureScaleDown(
809809
MlMemoryAutoscalingCapacity scaleDownResult,
810810
MlMemoryAutoscalingCapacity currentCapacity
811811
) {
812-
if (scaleDownResult == null || currentCapacity == null) {
812+
if (scaleDownResult == null || currentCapacity == null || currentCapacity.isUndetermined()) {
813813
return null;
814814
}
815815
MlMemoryAutoscalingCapacity newCapacity = MlMemoryAutoscalingCapacity.builder(

0 commit comments

Comments
 (0)