Skip to content

Commit 98dca65

Browse files
authored
Update SamlRealmTests to use TLSv1.2 only (#75324)
Recent JDK builds disable TLSv1 and TLSv1.1, which would cause this test to fail whenever it was (randomly) configured to use those protocols. For the purposes of this test it is no longer necessary to test with older protocols, and the test can rely on TLSv1.2 instead. Resolves: #73314
1 parent 61f3dae commit 98dca65

File tree

1 file changed

+1
-2
lines changed
  • x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/saml

1 file changed

+1
-2
lines changed

x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/saml/SamlRealmTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@
8585
/**
8686
* Basic unit tests for the SAMLRealm
8787
*/
88-
@SamlTestCase.AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/73314")
8988
public class SamlRealmTests extends SamlTestCase {
9089

9190
public static final String TEST_IDP_ENTITY_ID = "http://demo_josso_1.josso.dev.docker:8081/IDBUS/JOSSO-TUTORIAL/IDP1/SAML2/MD";
@@ -120,7 +119,7 @@ public void testReadIdpMetadataFromFile() throws Exception {
120119
}
121120

122121
public void testReadIdpMetadataFromHttps() throws Exception {
123-
final String serverProtocol = randomFrom("TLSv1", "TLSv1.1", "TLSv1.2");
122+
final String serverProtocol = "TLSv1.2";
124123
final Path path = getDataPath("idp1.xml");
125124
final String body = new String(Files.readAllBytes(path), StandardCharsets.UTF_8);
126125
final MockSecureSettings mockSecureSettings = new MockSecureSettings();

0 commit comments

Comments
 (0)