FileWatchingService should not throw for missing file (#126264)

Missing file is a valid state for FileWatchingService so that the
exception should be suppressed.

Author: ywangd

docs/changelog/126264.yaml

@@ -0,0 +1,5 @@
+pr: 126264
+summary: '`FileWatchingService` shoudld not throw for missing file'
+area: Infra/Settings
+type: enhancement
+issues: []

server/src/main/java/org/elasticsearch/common/file/AbstractFileWatchingService.java

@@ -116,15 +116,13 @@ public final boolean watching() {
     }
 
     private FileUpdateState readFileUpdateState(Path path) throws IOException {
-        BasicFileAttributes attr;
         try {
-            attr = filesReadAttributes(path, BasicFileAttributes.class);
+            BasicFileAttributes attr = filesReadAttributes(path, BasicFileAttributes.class);
+            return new FileUpdateState(attr.lastModifiedTime().toMillis(), path.toRealPath().toString(), attr.fileKey());
         } catch (NoSuchFileException e) {
             // file doesn't exist anymore
             return null;
         }
-
-        return new FileUpdateState(attr.lastModifiedTime().toMillis(), path.toRealPath().toString(), attr.fileKey());
     }
 
     // platform independent way to tell if a file changed