Tweak

Author: n1v0lg

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptor.java

@@ -1381,9 +1381,7 @@ public String[] getIndices() {
         public static Set<String> filterFailureIndices(Set<String> indices) {
             return indices.stream().filter(index -> {
                 // TODO improve check
-                return index != null
-                    && (index.endsWith("::" + IndexComponentSelector.FAILURES.getKey())
-                        || index.endsWith("::" + IndexComponentSelector.FAILURES.getKey() + "/"));
+                return index != null && index.endsWith("::" + IndexComponentSelector.FAILURES.getKey());
             }).collect(Collectors.toSet());
         }
 

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStore.java

@@ -653,13 +653,10 @@ public static void buildRoleFromDescriptors(
     private static String stripFailuresSuffix(String input) {
         // TODO clean up
         String literalSuffix = "::failures";
-        String regexSuffix = "::failures/";
         if (input.endsWith(literalSuffix)) {
             return input.substring(0, input.length() - literalSuffix.length());
-        } else if (input.endsWith(regexSuffix)) {
-            // TODO need to add back "/" since otherwise we break the regex
-            return input.substring(0, input.length() - regexSuffix.length());
         }
+        // TODO regex handling
         assert false : "unexpected failure index name: " + input;
         return input;
     }