Change return to continue (refactored from lambda to loop)

nicktindall · nicktindall · commit 9c88caeaff08 · 2025-11-05T14:40:25.000+11:00
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/allocation/WriteLoadConstraintMonitor.java b/server/src/main/java/org/elasticsearch/cluster/routing/allocation/WriteLoadConstraintMonitor.java
@@ -86,7 +86,7 @@ public void onNewInfo(ClusterInfo clusterInfo) {
             if (nodeRoles.contains(DiscoveryNodeRole.SEARCH_ROLE) || nodeRoles.contains(DiscoveryNodeRole.ML_ROLE)) {
                 // Search & ML nodes are not expected to have write load hot-spots and are not considered for shard relocation.
                 // TODO (ES-13314): consider stateful data tiers
-                return;
+                continue;
             }
             totalIngestNodes++;
             final NodeUsageStatsForThreadPools.ThreadPoolUsageStats writeThreadPoolStats = usageStats.threadPoolUsageStatsMap()

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public void onNewInfo(ClusterInfo clusterInfo) {`
`86`	`86`	`if (nodeRoles.contains(DiscoveryNodeRole.SEARCH_ROLE) \|\| nodeRoles.contains(DiscoveryNodeRole.ML_ROLE)) {`
`87`	`87`	`// Search & ML nodes are not expected to have write load hot-spots and are not considered for shard relocation.`
`88`	`88`	`// TODO (ES-13314): consider stateful data tiers`
`89`		`- return;`
	`89`	`+ continue;`
`90`	`90`	`}`
`91`	`91`	`totalIngestNodes++;`
`92`	`92`	`final NodeUsageStatsForThreadPools.ThreadPoolUsageStats writeThreadPoolStats = usageStats.threadPoolUsageStatsMap()`