PR feedback

prdoyle · prdoyle · commit 9c94c2abd203 · 2025-03-11T12:54:20.000-04:00
diff --git a/libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java b/libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java
@@ -549,7 +549,7 @@ private void notEntitled(String message, Class<?> callerClass, String componentN
             var notEntitledLogger = LogManager.getLogger(PolicyManager.class.getName() + loggerSuffix);
             String frameInfoSuffix = StackWalker.getInstance(RETAIN_CLASS_REFERENCE)
                 .walk(this::findRequestingFrame)
-                .map(StackFrame::toString)
+                .map(frame -> "\n\tat " + frame)
                 .orElse("");
             notEntitledLogger.warn(message + frameInfoSuffix);
         }
diff --git a/modules/repository-gcs/src/main/config/log4j2.properties b/modules/repository-gcs/src/main/config/log4j2.properties
@@ -1,3 +1,3 @@
-logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.name = org.elasticsearch.entitlement.runtime.policy.PolicyManager.repository-gcs
+logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.name = org.elasticsearch.entitlement.runtime.policy.PolicyManager.repository-gcs.ALL-UNNAMED
 logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.level = error
 
diff --git a/modules/repository-s3/src/main/config/log4j2.properties b/modules/repository-s3/src/main/config/log4j2.properties
@@ -13,6 +13,6 @@ logger.com_amazonaws_auth_profile_internal_BasicProfileConfigFileLoader.level =
 logger.com_amazonaws_services_s3_internal_UseArnRegionResolver.name = com.amazonaws.services.s3.internal.UseArnRegionResolver
 logger.com_amazonaws_services_s3_internal_UseArnRegionResolver.level = error
 
-logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.name = org.elasticsearch.entitlement.runtime.policy.PolicyManager.repository-s3
+logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.name = org.elasticsearch.entitlement.runtime.policy.PolicyManager.repository-s3.software.amazon.awssdk.profiles
 logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.level = error
 

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,7 @@ private void notEntitled(String message, Class<?> callerClass, String componentN`
`549`	`549`	`var notEntitledLogger = LogManager.getLogger(PolicyManager.class.getName() + loggerSuffix);`
`550`	`550`	`String frameInfoSuffix = StackWalker.getInstance(RETAIN_CLASS_REFERENCE)`
`551`	`551`	`.walk(this::findRequestingFrame)`
`552`		`- .map(StackFrame::toString)`
	`552`	`+ .map(frame -> "\n\tat " + frame)`
`553`	`553`	`.orElse("");`
`554`	`554`	`notEntitledLogger.warn(message + frameInfoSuffix);`
`555`	`555`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.name = org.elasticsearch.entitlement.runtime.policy.PolicyManager.repository-gcs`
	`1`	`+logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.name = org.elasticsearch.entitlement.runtime.policy.PolicyManager.repository-gcs.ALL-UNNAMED`
`2`	`2`	`logger.org_elasticsearch_entitlement_runtime_policy_PolicyManager.level = error`
`3`	`3`