Removing ElasticsearchInternalServiceModelValidator

Author: dan-rubinstein

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java

@@ -499,7 +499,7 @@ public Model parsePersistedConfig(String inferenceEntityId, TaskType taskType, M
 
     @Override
     public void checkModelConfig(Model model, ActionListener<Model> listener) {
-        ModelValidatorBuilder.buildModelValidator(model.getTaskType(), true).validate(this, model, listener);
+        ModelValidatorBuilder.buildModelValidator(model.getTaskType()).validate(this, model, listener);
     }
 
     @Override

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/validation/ElasticsearchInternalServiceModelValidator.java

@@ -11,18 +11,6 @@
 import org.elasticsearch.inference.TaskType;
 
 public class ModelValidatorBuilder {
-
-    // TODO: Once we merge all the other service validation code we can remove the checkModelConfig function
-    // from each service, private the buildModelValidator function below this one, and call this directly from
-    // TransportPutInferenceModelAction.java.
-    public static ModelValidator buildModelValidator(TaskType taskType, boolean isElasticsearchInternalService) {
-        if (isElasticsearchInternalService) {
-            return new ElasticsearchInternalServiceModelValidator(buildModelValidator(taskType));
-        } else {
-            return buildModelValidator(taskType);
-        }
-    }
-
     public static ModelValidator buildModelValidator(TaskType taskType) {
         if (taskType == null) {
             throw new IllegalArgumentException("Task type can't be null");