Skip to content

Commit 9d4c3f8

Browse files
authored
Fix concurrent list in merge test (#131186)
Fixes #131165
1 parent 86c7787 commit 9d4c3f8

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,6 @@ tests:
421421
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
422422
method: test {lookup-join.MvJoinKeyOnFromAfterStats ASYNC}
423423
issue: https://github.com/elastic/elasticsearch/issues/131148
424-
- class: org.elasticsearch.index.engine.ThreadPoolMergeExecutorServiceDiskSpaceTests
425-
method: testEnqueuedMergeTasksAreUnblockedWhenEstimatedMergeSizeChanges
426-
issue: https://github.com/elastic/elasticsearch/issues/131165
427424
- class: org.elasticsearch.xpack.esql.ccq.MultiClustersIT
428425
method: testLookupJoinAliases
429426
issue: https://github.com/elastic/elasticsearch/issues/131166

server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceDiskSpaceTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import org.elasticsearch.common.settings.ClusterSettings;
1515
import org.elasticsearch.common.settings.Settings;
1616
import org.elasticsearch.common.unit.ByteSizeValue;
17+
import org.elasticsearch.common.util.concurrent.ConcurrentCollections;
1718
import org.elasticsearch.common.util.concurrent.EsExecutors;
1819
import org.elasticsearch.core.PathUtils;
1920
import org.elasticsearch.core.PathUtilsForTesting;
@@ -40,6 +41,7 @@
4041
import java.util.IdentityHashMap;
4142
import java.util.LinkedHashSet;
4243
import java.util.List;
44+
import java.util.Set;
4345
import java.util.concurrent.CountDownLatch;
4446
import java.util.concurrent.Executor;
4547
import java.util.concurrent.TimeUnit;
@@ -898,8 +900,8 @@ public void testEnqueuedMergeTasksAreUnblockedWhenEstimatedMergeSizeChanges() th
898900
assertBusy(
899901
() -> assertThat(threadPoolMergeExecutorService.getDiskSpaceAvailableForNewMergeTasks(), is(expectedAvailableBudget.get()))
900902
);
901-
List<ThreadPoolMergeScheduler.MergeTask> tasksRunList = new ArrayList<>();
902-
List<ThreadPoolMergeScheduler.MergeTask> tasksAbortList = new ArrayList<>();
903+
Set<ThreadPoolMergeScheduler.MergeTask> tasksRunList = ConcurrentCollections.newConcurrentSet();
904+
Set<ThreadPoolMergeScheduler.MergeTask> tasksAbortList = ConcurrentCollections.newConcurrentSet();
903905
int submittedMergesCount = randomIntBetween(1, 5);
904906
long[] mergeSizeEstimates = new long[submittedMergesCount];
905907
for (int i = 0; i < submittedMergesCount; i++) {

0 commit comments

Comments
 (0)