add pipeline to set default success count to 1 is outcome success

Author: rubvs

x-pack/plugin/apm-data/src/main/resources/ingest-pipelines/[email protected]

@@ -30,13 +30,16 @@ processors:
     field: ["event.duration"]
     ignore_failure: true
     ignore_missing: true
-- script:
-    if: ctx.event?.outcome == 'success' && ctx[ctx.processor?.event]?.representative_count != null
-    source: |
-        ctx.event.success_count = ctx[ctx.processor?.event]?.representative_count;
 - set:
     if: ctx.event?.outcome == 'failure'
     field: event.success_count
     value: 0
+- set:
+    if: ctx.event?.outcome == 'success'
+    field: event.success_count
+    value: 1
+- script:
+    if: ctx.event?.outcome == 'success' && ctx[ctx.processor?.event]?.representative_count != null
+    source: ctx.event.success_count = ctx[ctx.processor?.event]?.representative_count;
 - pipeline:
     name: apm@pipeline

x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/20_traces_ingest.yml

@@ -95,6 +95,21 @@ setup:
             "span": {"representative_count": 3}
           }'
 
+          - create: {}
+          - '{
+            "@timestamp": "2017-06-22",
+            "processor": {"event": "span"},
+            "event": {"outcome": "success"},
+            "span": {"representative_count": null}
+          }'
+
+          - create: {}
+          - '{
+            "@timestamp": "2017-06-22",
+            "processor": {"event": "transaction"},
+            "event": {"outcome": "success"},
+          }'
+
           - create: {}
           - '{"@timestamp": "2017-06-22", "event": {"outcome": "failure"}}'
 
@@ -110,4 +125,6 @@ setup:
   - match: { hits.hits.1.fields: null }
   - match: { hits.hits.2.fields: {"event.success_count": [2]} }
   - match: { hits.hits.3.fields: {"event.success_count": [3]} }
-  - match: { hits.hits.4.fields: {"event.success_count": [0]} }
+  - match: { hits.hits.4.fields: {"event.success_count": [1]} }
+  - match: { hits.hits.5.fields: {"event.success_count": [1]} }
+  - match: { hits.hits.6.fields: {"event.success_count": [0]} }