Assert for empty routing table when hiding state (#117870)

Routing table should always be empty when hiding cluster state for
not-recovered block. This PR adds an explicit assertion for it.

Author: ywangd

server/src/main/java/org/elasticsearch/gateway/ClusterStateUpdaters.java

@@ -143,6 +143,7 @@ public static ClusterState hideStateIfNotRecovered(ClusterState state) {
                 .coordinationMetadata(state.metadata().coordinationMetadata())
                 .build();
 
+            assert state.routingTable().indicesRouting().isEmpty() : "routing table is not empty: " + state.routingTable().indicesRouting();
             return ClusterState.builder(state).metadata(metadata).blocks(blocks.build()).build();
         }
         return state;