Skip to content

Commit 9dab7db

Browse files
Add tests for user override behavior in LlamaChatCompletionModel
1 parent a6a854d commit 9dab7db

File tree

1 file changed

+37
-0
lines changed

1 file changed

+37
-0
lines changed

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/llama/completion/LlamaChatCompletionModelTests.java

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,48 @@
1616
import org.elasticsearch.xpack.inference.services.settings.DefaultSecretSettings;
1717

1818
import java.util.List;
19+
import java.util.Map;
1920

21+
import static org.elasticsearch.xpack.inference.services.openai.completion.OpenAiChatCompletionRequestTaskSettingsTests.getChatCompletionRequestTaskSettingsMap;
2022
import static org.hamcrest.Matchers.is;
23+
import static org.hamcrest.Matchers.sameInstance;
2124

2225
public class LlamaChatCompletionModelTests extends ESTestCase {
2326

27+
public void testOverrideWith_OverridesExistingUser() {
28+
var model = createCompletionModel("model_name", "url", "api_key", "user");
29+
var requestTaskSettingsMap = getChatCompletionRequestTaskSettingsMap("user_override");
30+
31+
var overriddenModel = LlamaChatCompletionModel.of(model, requestTaskSettingsMap);
32+
33+
assertThat(overriddenModel, is(createCompletionModel("model_name", "url", "api_key", "user_override")));
34+
}
35+
36+
public void testOverrideWith_OverridesNullUser() {
37+
var model = createCompletionModel("model_name", "url", "api_key", null);
38+
var requestTaskSettingsMap = getChatCompletionRequestTaskSettingsMap("user_override");
39+
40+
var overriddenModel = LlamaChatCompletionModel.of(model, requestTaskSettingsMap);
41+
42+
assertThat(overriddenModel, is(createCompletionModel("model_name", "url", "api_key", "user_override")));
43+
}
44+
45+
public void testOverrideWith_EmptyMap() {
46+
var model = createCompletionModel("model_name", "url", "api_key", null);
47+
48+
var requestTaskSettingsMap = Map.<String, Object>of();
49+
50+
var overriddenModel = LlamaChatCompletionModel.of(model, requestTaskSettingsMap);
51+
assertThat(overriddenModel, sameInstance(model));
52+
}
53+
54+
public void testOverrideWith_NullMap() {
55+
var model = createCompletionModel("model_name", "url", "api_key", null);
56+
57+
var overriddenModel = LlamaChatCompletionModel.of(model, (Map<String, Object>) null);
58+
assertThat(overriddenModel, sameInstance(model));
59+
}
60+
2461
public static LlamaChatCompletionModel createCompletionModel(String modelId, String url, String apiKey, String user) {
2562
return new LlamaChatCompletionModel(
2663
"id",

0 commit comments

Comments
 (0)