Use StreamOutput::writeWriteable instead of writeTo directly (#112027)

Author: thecoop

modules/data-streams/src/main/java/org/elasticsearch/datastreams/lifecycle/action/GetDataStreamLifecycleStatsAction.java

@@ -76,7 +76,7 @@ public Response(StreamInput in) throws IOException {
         public void writeTo(StreamOutput out) throws IOException {
             out.writeOptionalVLong(runDuration);
             out.writeOptionalVLong(timeBetweenStarts);
-            out.writeCollection(dataStreamStats, (o, v) -> v.writeTo(o));
+            out.writeCollection(dataStreamStats, StreamOutput::writeWriteable);
         }
 
         public Long getRunDuration() {

server/src/main/java/org/elasticsearch/cluster/ClusterState.java

@@ -1081,7 +1081,7 @@ public void writeTo(StreamOutput out) throws IOException {
         routingTable.writeTo(out);
         nodes.writeTo(out);
         if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_8_0)) {
-            out.writeMap(compatibilityVersions, (streamOutput, versions) -> versions.writeTo(streamOutput));
+            out.writeMap(compatibilityVersions, StreamOutput::writeWriteable);
         }
         if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_12_0)) {
             clusterFeatures.writeTo(out);

server/src/main/java/org/elasticsearch/cluster/version/CompatibilityVersions.java

@@ -120,7 +120,7 @@ public void writeTo(StreamOutput out) throws IOException {
         TransportVersion.writeVersion(this.transportVersion(), out);
 
         if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_11_X)) {
-            out.writeMap(this.systemIndexMappingsVersion(), (o, v) -> v.writeTo(o));
+            out.writeMap(this.systemIndexMappingsVersion(), StreamOutput::writeWriteable);
         }
     }
 

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/datatiers/NodeDataTiersUsage.java

@@ -108,6 +108,6 @@ public Map<String, UsageStats> getUsageStatsByTier() {
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);
-        out.writeMap(usageStatsByTier, (o, v) -> v.writeTo(o));
+        out.writeMap(usageStatsByTier, StreamOutput::writeWriteable);
     }
 }

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/enrich/EnrichPolicyResolver.java

@@ -332,7 +332,7 @@ private static class LookupResponse extends TransportResponse {
 
         @Override
         public void writeTo(StreamOutput out) throws IOException {
-            out.writeMap(policies, (o, v) -> v.writeTo(o));
+            out.writeMap(policies, StreamOutput::writeWriteable);
             out.writeMap(failures, StreamOutput::writeString);
         }
     }

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/Configuration.java

@@ -117,7 +117,7 @@ public void writeTo(StreamOutput out) throws IOException {
             out.writeBoolean(profile);
         }
         if (out.getTransportVersion().onOrAfter(TransportVersions.ESQL_REQUEST_TABLES)) {
-            out.writeMap(tables, (o1, columns) -> o1.writeMap(columns, (o2, column) -> column.writeTo(o2)));
+            out.writeMap(tables, (o1, columns) -> o1.writeMap(columns, StreamOutput::writeWriteable));
         }
     }