todo

martijnvg · martijnvg · commit 9e17d816cba4 · 2025-07-09T09:39:17.000+02:00
diff --git a/server/src/main/java/org/elasticsearch/index/fieldvisitor/IgnoredSourceFieldLoader.java b/server/src/main/java/org/elasticsearch/index/fieldvisitor/IgnoredSourceFieldLoader.java
@@ -111,7 +111,8 @@ public Status needsField(FieldInfo fieldInfo) throws IOException {
         public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException {
             var result = IgnoredSourceFieldMapper.decodeIfMatch(value, potentialFieldsInIgnoreSource);
             if (result != null) {
-                done = true;
+                // TODO: can't do this in case multiple entries for the same field name. (objects, arrays etc.)
+//                done = true;
                 values.add(result);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,8 @@ public Status needsField(FieldInfo fieldInfo) throws IOException {`
`111`	`111`	`public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException {`
`112`	`112`	`var result = IgnoredSourceFieldMapper.decodeIfMatch(value, potentialFieldsInIgnoreSource);`
`113`	`113`	`if (result != null) {`
`114`		`- done = true;`
	`114`	`+ // TODO: can't do this in case multiple entries for the same field name. (objects, arrays etc.)`
	`115`	`+// done = true;`
`115`	`116`	`values.add(result);`
`116`	`117`	`}`
`117`	`118`	`}`