Move setting to MappterService

Author: seanstory

server/src/main/java/org/elasticsearch/common/settings/IndexScopedSettings.java

@@ -175,6 +175,7 @@ public final class IndexScopedSettings extends AbstractScopedSettings {
                 MapperService.INDEX_MAPPING_DIMENSION_FIELDS_LIMIT_SETTING,
                 MapperService.INDEX_MAPPING_FIELD_NAME_LENGTH_LIMIT_SETTING,
                 MapperService.INDEX_MAPPER_DYNAMIC_SETTING,
+                MapperService.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING,
                 BitsetFilterCache.INDEX_LOAD_RANDOM_ACCESS_FILTERS_EAGERLY_SETTING,
                 IndexModule.INDEX_STORE_TYPE_SETTING,
                 IndexModule.INDEX_STORE_PRE_LOAD_SETTING,
@@ -206,7 +207,7 @@ public final class IndexScopedSettings extends AbstractScopedSettings {
                 IndexSettings.INDEX_MAPPER_SOURCE_MODE_SETTING,
                 IndexSettings.RECOVERY_USE_SYNTHETIC_SOURCE_SETTING,
                 InferenceMetadataFieldsMapper.USE_LEGACY_SEMANTIC_TEXT_FORMAT,
-                IndexSettings.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING,
+                // IndexSettings.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING,
 
                 // validate that built-in similarities don't get redefined
                 Setting.groupSetting("index.similarity.", (s) -> {

server/src/main/java/org/elasticsearch/index/IndexSettings.java

@@ -856,14 +856,6 @@ private static String getIgnoreAboveDefaultValue(final Settings settings) {
         Property.Final
     );
 
-    public static final Setting<Integer> INDEX_MAPPING_META_LENGTH_LIMIT_SETTING = Setting.intSetting(
-        "index.mapping.meta.length_limit",
-        500,
-        0,
-        Property.IndexScope,
-        Property.Final
-    );
-
     private final Index index;
     private final IndexVersion version;
     private final Logger logger;

server/src/main/java/org/elasticsearch/index/mapper/MapperService.java

@@ -175,6 +175,13 @@ public boolean isAutoUpdate() {
         Property.IndexScope,
         Property.IndexSettingDeprecatedInV7AndRemovedInV8
     );
+    public static final Setting<Integer> INDEX_MAPPING_META_LENGTH_LIMIT_SETTING = Setting.intSetting(
+        "index.mapping.meta.length_limit",
+        500,
+        0,
+        Property.IndexScope,
+        Property.Final
+    );
 
     private final IndexAnalyzers indexAnalyzers;
     private final MappingParser mappingParser;

server/src/main/java/org/elasticsearch/index/mapper/TypeParsers.java

@@ -24,7 +24,7 @@
 
 import static org.elasticsearch.common.xcontent.support.XContentMapValues.isArray;
 import static org.elasticsearch.common.xcontent.support.XContentMapValues.nodeStringValue;
-import static org.elasticsearch.index.IndexSettings.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING;
+import static org.elasticsearch.index.mapper.MapperService.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING;
 
 public class TypeParsers {
     private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(TypeParsers.class);

server/src/test/java/org/elasticsearch/index/mapper/TypeParsersTests.java

@@ -38,6 +38,7 @@
 import static org.elasticsearch.index.analysis.AnalysisRegistry.DEFAULT_ANALYZER_NAME;
 import static org.elasticsearch.index.analysis.AnalysisRegistry.DEFAULT_SEARCH_ANALYZER_NAME;
 import static org.elasticsearch.index.analysis.AnalysisRegistry.DEFAULT_SEARCH_QUOTED_ANALYZER_NAME;
+import static org.elasticsearch.index.mapper.MapperService.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING;
 import static org.hamcrest.core.IsEqual.equalTo;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -199,7 +200,7 @@ public void testParseMeta() {
                 .put(IndexMetadata.SETTING_VERSION_CREATED, IndexVersion.current())
                 .put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, 1)
                 .put(IndexMetadata.SETTING_NUMBER_OF_SHARDS, 1)
-                .put(IndexSettings.INDEX_MAPPING_META_LENGTH_LIMIT_SETTING.getKey(), 300)
+                .put(INDEX_MAPPING_META_LENGTH_LIMIT_SETTING.getKey(), 300)
                 .build();
             MappingParserContext otherParserContext = createParserContext(otherSettings);
             String longString = IntStream.range(0, 301).mapToObj(Integer::toString).collect(Collectors.joining());