Fix bugs

Author: mayya-sharipova

server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

@@ -3018,7 +3018,9 @@ public KnnVectorsFormat getKnnVectorsFormatForField(KnnVectorsFormat defaultForm
             List<KnnVectorsFormat> extraKnnFormats = new ArrayList<>();
             for (VectorsFormatProvider vectorsFormatProvider : extraVectorsFormatProviders) {
                 KnnVectorsFormat extraKnnFormat = vectorsFormatProvider.getKnnVectorsFormat(indexSettings, indexOptions);
-                extraKnnFormats.add(extraKnnFormat);
+                if (extraKnnFormat != null) {
+                    extraKnnFormats.add(extraKnnFormat);
+                }
             }
             if (extraKnnFormats.size() > 0) {
                 format = extraKnnFormats.get(0);

server/src/main/java/org/elasticsearch/index/mapper/vectors/VectorsFormatProvider.java

@@ -20,6 +20,7 @@ public interface VectorsFormatProvider {
 
     /**
      * Returns a {@link KnnVectorsFormat} instance based on the provided index settings and vector index options.
+     * May return {@code null} if the provider does not support the format for the given index settings or vector index options.
      *
      * @param indexSettings The index settings.
      * @param indexOptions The dense vector index options.

x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/GPUToHNSWVectorsWriter.java

@@ -43,7 +43,6 @@
 import org.elasticsearch.logging.Logger;
 
 import java.io.IOException;
-import java.io.UncheckedIOException;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
 import java.util.ArrayList;
@@ -470,7 +469,6 @@ public NodesIterator getNodesOnLevel(int level) {
     @SuppressForbidden(reason = "require usage of Lucene's IOUtils#deleteFilesIgnoringExceptions(...)")
     public void mergeOneField(FieldInfo fieldInfo, MergeState mergeState) throws IOException {
         flatVectorWriter.mergeOneField(fieldInfo, mergeState);
-        FloatVectorValues vectorValues = KnnVectorsWriter.MergedVectorValues.mergeFloatVectorValues(fieldInfo, mergeState);
         // save merged vector values to a temp file
         final int numVectors;
         String tempRawVectorsFileName = null;
@@ -487,9 +485,8 @@ public void mergeOneField(FieldInfo fieldInfo, MergeState mergeState) throws IOE
         }
         try (IndexInput in = mergeState.segmentInfo.dir.openInput(tempRawVectorsFileName, IOContext.DEFAULT)) {
             DatasetOrVectors datasetOrVectors;
-
             var input = FilterIndexInput.unwrapOnlyTest(in);
-            if (input instanceof MemorySegmentAccessInput memorySegmentAccessInput) {
+            if (input instanceof MemorySegmentAccessInput memorySegmentAccessInput && numVectors >= MIN_NUM_VECTORS_FOR_GPU_BUILD) {
                 var ds = DatasetUtils.getInstance().fromInput(memorySegmentAccessInput, numVectors, fieldInfo.getVectorDimension());
                 datasetOrVectors = DatasetOrVectors.fromDataset(ds);
             } else {
@@ -521,7 +518,6 @@ private static int writeFloatVectorValues(FieldInfo fieldInfo, IndexOutput out,
         for (int docV = iterator.nextDoc(); docV != NO_MORE_DOCS; docV = iterator.nextDoc()) {
             numVectors++;
             float[] vector = floatVectorValues.vectorValue(iterator.index());
-            out.writeInt(iterator.docID());
             buffer.asFloatBuffer().put(vector);
             out.writeBytes(buffer.array(), buffer.array().length);
         }
@@ -532,12 +528,12 @@ private static FloatVectorValues getFloatVectorValues(FieldInfo fieldInfo, Index
         if (numVectors == 0) {
             return FloatVectorValues.fromFloats(List.of(), fieldInfo.getVectorDimension());
         }
-        final long length = (long) Float.BYTES * fieldInfo.getVectorDimension() + Integer.BYTES;
+        final long length = (long) Float.BYTES * fieldInfo.getVectorDimension();
         final float[] vector = new float[fieldInfo.getVectorDimension()];
         return new FloatVectorValues() {
             @Override
             public float[] vectorValue(int ord) throws IOException {
-                randomAccessInput.seek(ord * length + Integer.BYTES);
+                randomAccessInput.seek(ord * length);
                 randomAccessInput.readFloats(vector, 0, vector.length);
                 return vector;
             }
@@ -559,12 +555,7 @@ public int size() {
 
             @Override
             public int ordToDoc(int ord) {
-                try {
-                    randomAccessInput.seek(ord * length);
-                    return randomAccessInput.readInt();
-                } catch (IOException e) {
-                    throw new UncheckedIOException(e);
-                }
+                throw new UnsupportedOperationException("Not implemented");
             }
         };
     }

x-pack/plugin/gpu/src/main21/java/org/elasticsearch/xpack/gpu/codec/DatasetUtilsImpl.java

@@ -49,23 +49,23 @@ public Dataset fromInput(MemorySegmentAccessInput input, int numVectors, int dim
         }
         MemorySegment ms = input.segmentSliceOrNull(0L, input.length());
         assert ms != null; // TODO: this can be null if larger than 16GB or ...
-        if (((long) numVectors * dims * Float.BYTES) < ms.byteSize()) {
+        if (((long) numVectors * dims * Float.BYTES) > ms.byteSize()) {
             throwIllegalArgumentException(ms, numVectors, dims);
         }
         return fromMemorySegment(ms, numVectors, dims);
     }
 
     static void throwIllegalArgumentException(MemorySegment ms, int numVectors, int dims) {
-        var s = "segment of size [" + ms.byteSize() + "] too small for expected " + numVectors + " float vectors of " + dims + "dimensions";
+        var s = "segment of size [" + ms.byteSize() + "] too small for expected " + numVectors + " float vectors of " + dims + " dims";
         throw new IllegalArgumentException(s);
     }
 
     static void throwIllegalArgumentException(int numVectors, int dims) {
         String s;
         if (numVectors < 0) {
-            s = "negative number of vectors:" + numVectors;
+            s = "negative number of vectors: " + numVectors;
         } else {
-            s = "negative vector dims:" + dims;
+            s = "negative vector dims: " + dims;
         }
         throw new IllegalArgumentException(s);
     }