randomize testing to select ENABLED or LOW_THRESHOLD_ONLY

Author: DiannaHohensee

server/src/internalClusterTest/java/org/elasticsearch/cluster/ClusterInfoServiceIT.java

@@ -344,7 +344,9 @@ public void testClusterInfoIncludesNodeUsageStatsForThreadPools() {
         var settings = Settings.builder()
             .put(
                 WriteLoadConstraintSettings.WRITE_LOAD_DECIDER_ENABLED_SETTING.getKey(),
-                WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                randomBoolean()
+                    ? WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                    : WriteLoadConstraintSettings.WriteLoadDeciderStatus.LOW_THRESHOLD_ONLY
             )
             .build();
         var masterName = internalCluster().startMasterOnlyNode(settings);

server/src/internalClusterTest/java/org/elasticsearch/index/shard/IndexShardIT.java

@@ -319,7 +319,9 @@ public void testNodeWriteLoadsArePresent() {
             Settings.builder()
                 .put(
                     WriteLoadConstraintSettings.WRITE_LOAD_DECIDER_ENABLED_SETTING.getKey(),
-                    WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                    randomBoolean()
+                        ? WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                        : WriteLoadConstraintSettings.WriteLoadDeciderStatus.LOW_THRESHOLD_ONLY
                 )
                 .build()
         );
@@ -376,7 +378,9 @@ public void testShardWriteLoadsArePresent() {
             Settings.builder()
                 .put(
                     WriteLoadConstraintSettings.WRITE_LOAD_DECIDER_ENABLED_SETTING.getKey(),
-                    WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                    randomBoolean()
+                        ? WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                        : WriteLoadConstraintSettings.WriteLoadDeciderStatus.LOW_THRESHOLD_ONLY
                 )
                 .build()
         );

server/src/test/java/org/elasticsearch/cluster/InternalClusterInfoServiceSchedulingTests.java

@@ -62,7 +62,9 @@ public void testScheduling() {
             .put(InternalClusterInfoService.CLUSTER_ROUTING_ALLOCATION_ESTIMATED_HEAP_THRESHOLD_DECIDER_ENABLED.getKey(), true)
             .put(
                 WriteLoadConstraintSettings.WRITE_LOAD_DECIDER_ENABLED_SETTING.getKey(),
-                WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                randomBoolean()
+                    ? WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                    : WriteLoadConstraintSettings.WriteLoadDeciderStatus.LOW_THRESHOLD_ONLY
             );
         if (randomBoolean()) {
             settingsBuilder.put(INTERNAL_CLUSTER_INFO_UPDATE_INTERVAL_SETTING.getKey(), randomIntBetween(10000, 60000) + "ms");

server/src/test/java/org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDeciderTests.java

@@ -44,7 +44,7 @@ public void testWriteLoadDecider() {
          */
 
         ClusterState clusterState = ClusterStateCreationUtils.stateWithAssignedPrimariesAndReplicas(new String[] { indexName }, 3, 1);
-        // The number of data nodes the util method above creates is numberOfReplicas+1.
+        // The number of data nodes the util method above creates is numberOfReplicas+1, and three data nodes are needed for this test.
         assertEquals(3, clusterState.nodes().size());
         assertEquals(1, clusterState.metadata().getTotalNumberOfIndices());
 
@@ -176,7 +176,9 @@ public void testWriteLoadDecider() {
             Settings.builder()
                 .put(
                     WriteLoadConstraintSettings.WRITE_LOAD_DECIDER_ENABLED_SETTING.getKey(),
-                    WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                    randomBoolean()
+                        ? WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED
+                        : WriteLoadConstraintSettings.WriteLoadDeciderStatus.LOW_THRESHOLD_ONLY
                 )
                 .build()
         );