Rename PutLifecycleMetadataService to LifecycleMetadataService

Author: jbaiera

x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/IndexLifecycle.java

@@ -141,15 +141,15 @@ protected XPackLicenseState getLicenseState() {
     @Override
     public Collection<?> createComponents(PluginServices services) {
         final List<Object> components = new ArrayList<>();
-        PutLifecycleMetadataService putLifecycleMetadataService = new PutLifecycleMetadataService(
+        LifecycleMetadataService lifecycleMetadataService = new LifecycleMetadataService(
             services.clusterService(),
             services.xContentRegistry(),
             services.client(),
             getLicenseState(),
             services.threadPool(),
             services.projectResolver()
         );
-        components.add(putLifecycleMetadataService);
+        components.add(lifecycleMetadataService);
 
         ILMHistoryTemplateRegistry ilmTemplateRegistry = new ILMHistoryTemplateRegistry(
             settings,

…ack/ilm/PutLifecycleMetadataService.java …/xpack/ilm/LifecycleMetadataService.javax-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/PutLifecycleMetadataService.java renamed to x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/LifecycleMetadataService.java x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/PutLifecycleMetadataService.java renamed to x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/LifecycleMetadataService.java

@@ -52,9 +52,9 @@
 import static org.elasticsearch.xpack.core.ilm.PhaseCacheManagement.updateIndicesForPolicy;
 import static org.elasticsearch.xpack.core.searchablesnapshots.SearchableSnapshotsConstants.SEARCHABLE_SNAPSHOT_FEATURE;
 
-public class PutLifecycleMetadataService {
+public class LifecycleMetadataService {
 
-    private static final Logger logger = LogManager.getLogger(PutLifecycleMetadataService.class);
+    private static final Logger logger = LogManager.getLogger(LifecycleMetadataService.class);
 
     private final NamedXContentRegistry xContentRegistry;
     private final Client client;
@@ -63,7 +63,7 @@ public class PutLifecycleMetadataService {
     private final ProjectResolver projectResolver;
     private final MasterServiceTaskQueue<UpdateLifecyclePolicyTask> taskQueue;
 
-    public PutLifecycleMetadataService(
+    public LifecycleMetadataService(
         ClusterService clusterService,
         NamedXContentRegistry xContentRegistry,
         Client client,

x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/action/ReservedLifecycleAction.java

@@ -22,7 +22,7 @@
 import org.elasticsearch.xpack.core.ilm.LifecyclePolicy;
 import org.elasticsearch.xpack.core.ilm.action.DeleteLifecycleAction;
 import org.elasticsearch.xpack.core.ilm.action.PutLifecycleRequest;
-import org.elasticsearch.xpack.ilm.PutLifecycleMetadataService;
+import org.elasticsearch.xpack.ilm.LifecycleMetadataService;
 
 import java.io.IOException;
 import java.util.ArrayList;
@@ -87,7 +87,7 @@ public TransformState transform(ProjectId projectId, List<LifecyclePolicy> sourc
         ClusterState state = prevState.state();
 
         for (var request : requests) {
-            PutLifecycleMetadataService.UpdateLifecyclePolicyTask task = new PutLifecycleMetadataService.UpdateLifecyclePolicyTask(
+            LifecycleMetadataService.UpdateLifecyclePolicyTask task = new LifecycleMetadataService.UpdateLifecyclePolicyTask(
                 state.metadata().getProject(projectId).id(),
                 request,
                 licenseState,

x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/action/TransportPutLifecycleAction.java

@@ -23,7 +23,7 @@
 import org.elasticsearch.xpack.core.ilm.IndexLifecycleMetadata;
 import org.elasticsearch.xpack.core.ilm.action.ILMActions;
 import org.elasticsearch.xpack.core.ilm.action.PutLifecycleRequest;
-import org.elasticsearch.xpack.ilm.PutLifecycleMetadataService;
+import org.elasticsearch.xpack.ilm.LifecycleMetadataService;
 
 import java.util.Optional;
 import java.util.Set;
@@ -34,15 +34,15 @@
  */
 public class TransportPutLifecycleAction extends TransportMasterNodeAction<PutLifecycleRequest, AcknowledgedResponse> {
 
-    private final PutLifecycleMetadataService putLifecycleMetadataService;
+    private final LifecycleMetadataService lifecycleMetadataService;
 
     @Inject
     public TransportPutLifecycleAction(
         TransportService transportService,
         ClusterService clusterService,
         ThreadPool threadPool,
         ActionFilters actionFilters,
-        PutLifecycleMetadataService putLifecycleMetadataService
+        LifecycleMetadataService lifecycleMetadataService
     ) {
         super(
             ILMActions.PUT.name(),
@@ -54,7 +54,7 @@ public TransportPutLifecycleAction(
             AcknowledgedResponse::readFrom,
             EsExecutors.DIRECT_EXECUTOR_SERVICE
         );
-        this.putLifecycleMetadataService = putLifecycleMetadataService;
+        this.lifecycleMetadataService = lifecycleMetadataService;
     }
 
     @Override
@@ -64,7 +64,7 @@ protected void masterOperation(
         ClusterState state,
         ActionListener<AcknowledgedResponse> listener
     ) {
-        putLifecycleMetadataService.addLifecycle(request, state, listener);
+        lifecycleMetadataService.addLifecycle(request, state, listener);
     }
 
     @Override

x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/ilm/action/TransportPutLifecycleActionTests.java

@@ -20,7 +20,7 @@
 import org.elasticsearch.xpack.core.ilm.LifecyclePolicyMetadata;
 import org.elasticsearch.xpack.core.ilm.action.PutLifecycleRequest;
 import org.elasticsearch.xpack.ilm.LifecyclePolicyTestsUtils;
-import org.elasticsearch.xpack.ilm.PutLifecycleMetadataService;
+import org.elasticsearch.xpack.ilm.LifecycleMetadataService;
 
 import java.util.Map;
 
@@ -37,10 +37,10 @@ public void testIsNoop() {
 
         LifecyclePolicyMetadata existing = new LifecyclePolicyMetadata(policy1, headers1, randomNonNegativeLong(), randomNonNegativeLong());
 
-        assertTrue(PutLifecycleMetadataService.isNoopUpdate(existing, policy1, headers1));
-        assertFalse(PutLifecycleMetadataService.isNoopUpdate(existing, policy2, headers1));
-        assertFalse(PutLifecycleMetadataService.isNoopUpdate(existing, policy1, headers2));
-        assertFalse(PutLifecycleMetadataService.isNoopUpdate(null, policy1, headers1));
+        assertTrue(LifecycleMetadataService.isNoopUpdate(existing, policy1, headers1));
+        assertFalse(LifecycleMetadataService.isNoopUpdate(existing, policy2, headers1));
+        assertFalse(LifecycleMetadataService.isNoopUpdate(existing, policy1, headers2));
+        assertFalse(LifecycleMetadataService.isNoopUpdate(null, policy1, headers1));
     }
 
     public void testReservedStateHandler() throws Exception {
@@ -52,7 +52,7 @@ public void testReservedStateHandler() throws Exception {
             mockClusterService,
             threadPool,
             mock(ActionFilters.class),
-            mock(PutLifecycleMetadataService.class)
+            mock(LifecycleMetadataService.class)
         );
         assertEquals(ReservedLifecycleAction.NAME, putAction.reservedStateHandlerName().get());