more efficient update

ywangd · ywangd · commit a257d398d36d · 2025-06-02T10:07:51.000+10:00
diff --git a/server/src/main/java/org/elasticsearch/repositories/ShardGenerations.java b/server/src/main/java/org/elasticsearch/repositories/ShardGenerations.java
@@ -254,18 +254,18 @@ public Builder put(IndexId indexId, int shardId, ShardGeneration generation) {
             return this;
         }
 
-        private Builder updateIfPresent(ShardGenerations shardGenerations) {
+        private void updateIfPresent(ShardGenerations shardGenerations) {
             shardGenerations.shardGenerations.forEach((indexId, gens) -> {
-                if (generations.containsKey(indexId)) {
+                final Map<Integer, ShardGeneration> existingShardGens = generations.get(indexId);
+                if (existingShardGens != null) {
                     for (int i = 0; i < gens.size(); i++) {
                         final ShardGeneration gen = gens.get(i);
                         if (gen != null) {
-                            generations.get(indexId).put(i, gen);
+                            existingShardGens.put(i, gen);
                         }
                     }
                 }
             });
-            return this;
         }
 
         private boolean noDuplicateIndicesWithSameName(IndexId newId) {

Original file line number	Diff line number	Diff line change
`@@ -254,18 +254,18 @@ public Builder put(IndexId indexId, int shardId, ShardGeneration generation) {`
`254`	`254`	`return this;`
`255`	`255`	`}`
`256`	`256`
`257`		`- private Builder updateIfPresent(ShardGenerations shardGenerations) {`
	`257`	`+ private void updateIfPresent(ShardGenerations shardGenerations) {`
`258`	`258`	`shardGenerations.shardGenerations.forEach((indexId, gens) -> {`
`259`		`- if (generations.containsKey(indexId)) {`
	`259`	`+ final Map<Integer, ShardGeneration> existingShardGens = generations.get(indexId);`
	`260`	`+ if (existingShardGens != null) {`
`260`	`261`	`for (int i = 0; i < gens.size(); i++) {`
`261`	`262`	`final ShardGeneration gen = gens.get(i);`
`262`	`263`	`if (gen != null) {`
`263`		`- generations.get(indexId).put(i, gen);`
	`264`	`+ existingShardGens.put(i, gen);`
`264`	`265`	`}`
`265`	`266`	`}`
`266`	`267`	`}`
`267`	`268`	`});`
`268`		`- return this;`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`private boolean noDuplicateIndicesWithSameName(IndexId newId) {`