Remove assumed features in server for 9.0 (#119946)

All features added before 8.18 can now be assumed and removed in 9.0

Author: thecoop

modules/data-streams/src/main/java/org/elasticsearch/datastreams/DataStreamFeatures.java

@@ -9,10 +9,6 @@
 
 package org.elasticsearch.datastreams;
 
-import org.elasticsearch.action.admin.indices.rollover.LazyRolloverAction;
-import org.elasticsearch.action.datastreams.autosharding.DataStreamAutoShardingService;
-import org.elasticsearch.cluster.metadata.DataStreamGlobalRetention;
-import org.elasticsearch.datastreams.lifecycle.health.DataStreamLifecycleHealthInfoPublisher;
 import org.elasticsearch.features.FeatureSpecification;
 import org.elasticsearch.features.NodeFeature;
 
@@ -27,12 +23,7 @@ public class DataStreamFeatures implements FeatureSpecification {
 
     @Override
     public Set<NodeFeature> getFeatures() {
-        return Set.of(
-            DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE,  // Added in 8.12
-            LazyRolloverAction.DATA_STREAM_LAZY_ROLLOVER,                    // Added in 8.13
-            DataStreamAutoShardingService.DATA_STREAM_AUTO_SHARDING_FEATURE,
-            DataStreamGlobalRetention.GLOBAL_RETENTION                       // Added in 8.14
-        );
+        return Set.of();
     }
 
     @Override

modules/data-streams/src/main/java/org/elasticsearch/datastreams/DataStreamsPlugin.java

@@ -197,8 +197,7 @@ public Collection<?> createComponents(PluginServices services) {
                 settings,
                 services.client(),
                 services.clusterService(),
-                errorStoreInitialisationService.get(),
-                services.featureService()
+                errorStoreInitialisationService.get()
             )
         );
         dataLifecycleInitialisationService.set(

modules/data-streams/src/main/java/org/elasticsearch/datastreams/lifecycle/health/DataStreamLifecycleHealthInfoPublisher.java

@@ -19,8 +19,6 @@
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.datastreams.lifecycle.DataStreamLifecycleErrorStore;
-import org.elasticsearch.features.FeatureService;
-import org.elasticsearch.features.NodeFeature;
 import org.elasticsearch.health.node.DataStreamLifecycleHealthInfo;
 import org.elasticsearch.health.node.DslErrorInfo;
 import org.elasticsearch.health.node.UpdateHealthInfoCacheAction;
@@ -45,26 +43,22 @@ public class DataStreamLifecycleHealthInfoPublisher {
         Setting.Property.Dynamic,
         Setting.Property.NodeScope
     );
-    public static final NodeFeature DSL_HEALTH_INFO_FEATURE = new NodeFeature("health.dsl.info", true);
 
     private final Client client;
     private final ClusterService clusterService;
     private final DataStreamLifecycleErrorStore errorStore;
-    private final FeatureService featureService;
     private volatile int signallingErrorRetryInterval;
     private volatile int maxNumberOfErrorsToPublish;
 
     public DataStreamLifecycleHealthInfoPublisher(
         Settings settings,
         Client client,
         ClusterService clusterService,
-        DataStreamLifecycleErrorStore errorStore,
-        FeatureService featureService
+        DataStreamLifecycleErrorStore errorStore
     ) {
         this.client = client;
         this.clusterService = clusterService;
         this.errorStore = errorStore;
-        this.featureService = featureService;
         this.signallingErrorRetryInterval = DATA_STREAM_SIGNALLING_ERROR_RETRY_INTERVAL_SETTING.get(settings);
         this.maxNumberOfErrorsToPublish = DATA_STREAM_LIFECYCLE_MAX_ERRORS_TO_PUBLISH_SETTING.get(settings);
     }
@@ -89,9 +83,6 @@ private void updateNumberOfErrorsToPublish(int newValue) {
      * {@link org.elasticsearch.datastreams.lifecycle.DataStreamLifecycleService#DATA_STREAM_SIGNALLING_ERROR_RETRY_INTERVAL_SETTING}
      */
     public void publishDslErrorEntries(ActionListener<AcknowledgedResponse> actionListener) {
-        if (featureService.clusterHasFeature(clusterService.state(), DSL_HEALTH_INFO_FEATURE) == false) {
-            return;
-        }
         // fetching the entries that persist in the error store for more than the signalling retry interval
         // note that we're reporting this view into the error store on every publishing iteration
         List<DslErrorInfo> errorEntriesToSignal = errorStore.getErrorsInfo(

modules/data-streams/src/test/java/org/elasticsearch/datastreams/lifecycle/DataStreamLifecycleServiceTests.java

@@ -67,9 +67,7 @@
 import org.elasticsearch.common.unit.ByteSizeValue;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.core.Tuple;
-import org.elasticsearch.datastreams.DataStreamFeatures;
 import org.elasticsearch.datastreams.lifecycle.health.DataStreamLifecycleHealthInfoPublisher;
-import org.elasticsearch.features.FeatureService;
 import org.elasticsearch.index.Index;
 import org.elasticsearch.index.IndexMode;
 import org.elasticsearch.index.IndexSettings;
@@ -183,13 +181,7 @@ public void setupServices() {
             () -> now,
             errorStore,
             allocationService,
-            new DataStreamLifecycleHealthInfoPublisher(
-                Settings.EMPTY,
-                client,
-                clusterService,
-                errorStore,
-                new FeatureService(List.of(new DataStreamFeatures()))
-            ),
+            new DataStreamLifecycleHealthInfoPublisher(Settings.EMPTY, client, clusterService, errorStore),
             globalRetentionSettings
         );
         clientDelegate = null;
@@ -1465,13 +1457,7 @@ public void testTrackingTimeStats() {
             () -> now.getAndAdd(delta),
             errorStore,
             mock(AllocationService.class),
-            new DataStreamLifecycleHealthInfoPublisher(
-                Settings.EMPTY,
-                getTransportRequestsRecordingClient(),
-                clusterService,
-                errorStore,
-                new FeatureService(List.of(new DataStreamFeatures()))
-            ),
+            new DataStreamLifecycleHealthInfoPublisher(Settings.EMPTY, getTransportRequestsRecordingClient(), clusterService, errorStore),
             globalRetentionSettings
         );
         assertThat(service.getLastRunDuration(), is(nullValue()));

modules/data-streams/src/test/java/org/elasticsearch/datastreams/lifecycle/health/DataStreamLifecycleHealthInfoPublisherTests.java

@@ -24,10 +24,8 @@
 import org.elasticsearch.common.settings.ClusterSettings;
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Settings;
-import org.elasticsearch.datastreams.DataStreamFeatures;
 import org.elasticsearch.datastreams.lifecycle.DataStreamLifecycleErrorStore;
 import org.elasticsearch.datastreams.lifecycle.DataStreamLifecycleService;
-import org.elasticsearch.features.FeatureService;
 import org.elasticsearch.health.node.DataStreamLifecycleHealthInfo;
 import org.elasticsearch.health.node.DslErrorInfo;
 import org.elasticsearch.health.node.UpdateHealthInfoCacheAction;
@@ -40,7 +38,6 @@
 
 import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.CopyOnWriteArrayList;
 
@@ -83,13 +80,7 @@ public void setupServices() {
 
         final Client client = getTransportRequestsRecordingClient();
         errorStore = new DataStreamLifecycleErrorStore(() -> now);
-        dslHealthInfoPublisher = new DataStreamLifecycleHealthInfoPublisher(
-            Settings.EMPTY,
-            client,
-            clusterService,
-            errorStore,
-            new FeatureService(List.of(new DataStreamFeatures()))
-        );
+        dslHealthInfoPublisher = new DataStreamLifecycleHealthInfoPublisher(Settings.EMPTY, client, clusterService, errorStore);
     }
 
     @After
@@ -105,16 +96,6 @@ public void testPublishDslErrorEntries() {
         }
         errorStore.recordError("testIndex", new IllegalStateException("bad state"));
         ClusterState stateWithHealthNode = ClusterStateCreationUtils.state(node1, node1, node1, allNodes);
-        stateWithHealthNode = ClusterState.builder(stateWithHealthNode)
-            .nodeFeatures(
-                Map.of(
-                    node1.getId(),
-                    Set.of(DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE.id()),
-                    node2.getId(),
-                    Set.of(DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE.id())
-                )
-            )
-            .build();
         ClusterServiceUtils.setState(clusterService, stateWithHealthNode);
         dslHealthInfoPublisher.publishDslErrorEntries(new ActionListener<>() {
             @Override
@@ -143,16 +124,6 @@ public void testPublishDslErrorEntriesNoHealthNode() {
         errorStore.recordError("testIndex", new IllegalStateException("bad state"));
 
         ClusterState stateNoHealthNode = ClusterStateCreationUtils.state(node1, node1, null, allNodes);
-        stateNoHealthNode = ClusterState.builder(stateNoHealthNode)
-            .nodeFeatures(
-                Map.of(
-                    node1.getId(),
-                    Set.of(DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE.id()),
-                    node2.getId(),
-                    Set.of(DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE.id())
-                )
-            )
-            .build();
         ClusterServiceUtils.setState(clusterService, stateNoHealthNode);
         dslHealthInfoPublisher.publishDslErrorEntries(new ActionListener<>() {
             @Override
@@ -170,16 +141,6 @@ public void onFailure(Exception e) {
     public void testPublishDslErrorEntriesEmptyErrorStore() {
         // publishes the empty error store (this is the "back to healthy" state where all errors have been fixed)
         ClusterState state = ClusterStateCreationUtils.state(node1, node1, node1, allNodes);
-        state = ClusterState.builder(state)
-            .nodeFeatures(
-                Map.of(
-                    node1.getId(),
-                    Set.of(DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE.id()),
-                    node2.getId(),
-                    Set.of(DataStreamLifecycleHealthInfoPublisher.DSL_HEALTH_INFO_FEATURE.id())
-                )
-            )
-            .build();
         ClusterServiceUtils.setState(clusterService, state);
         dslHealthInfoPublisher.publishDslErrorEntries(new ActionListener<>() {
             @Override

modules/data-streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/150_tsdb.yml

@@ -300,9 +300,6 @@ index without timestamp with pipeline:
 
 ---
 dynamic templates:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -450,9 +447,6 @@ dynamic templates:
 
 ---
 dynamic templates - conflicting aliases:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -549,9 +543,6 @@ dynamic templates - conflicting aliases:
 
 ---
 dynamic templates - conflicting aliases with top-level field:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [otel] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -632,9 +623,6 @@ dynamic templates - conflicting aliases with top-level field:
 
 ---
 dynamic templates with nesting:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -810,10 +798,6 @@ dynamic templates with nesting:
 
 ---
 dynamic templates with incremental indexing:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
-
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -1038,9 +1022,6 @@ dynamic templates with incremental indexing:
 
 ---
 subobject in passthrough object auto flatten:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
   - do:
       allowed_warnings:
         - "index template [my-passthrough-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-passthrough-template] will take precedence during new index creation"
@@ -1108,9 +1089,6 @@ enable subobjects in passthrough object:
 
 ---
 passthrough objects with duplicate priority:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority"]
-      reason: support for priority in passthrough objects
   - do:
       catch: /has a conflicting param/
       indices.put_index_template:
@@ -1135,9 +1113,6 @@ passthrough objects with duplicate priority:
 
 ---
 dimensions with ignore_malformed and ignore_above:
-  - requires:
-      cluster_features: ["mapper.keyword_dimension_ignore_above"]
-      reason: support for ignore_above on keyword dimensions
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -1229,9 +1204,6 @@ dimensions with ignore_malformed and ignore_above:
 
 ---
 non string dimension fields:
-  - requires:
-      cluster_features: ["mapper.pass_through_priority", "routing.boolean_routing_path", "mapper.boolean_dimension"]
-      reason: support for priority in passthrough objects
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"
@@ -1339,10 +1311,6 @@ non string dimension fields:
 
 ---
 multi value dimensions:
-  - requires:
-      cluster_features: ["routing.multi_value_routing_path"]
-      reason: support for multi-value dimensions
-
   - do:
       allowed_warnings:
         - "index template [my-dynamic-template] has index patterns [k9s*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [my-dynamic-template] will take precedence during new index creation"

modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/direct/DatabaseConfiguration.java

@@ -160,11 +160,6 @@ public void writeTo(StreamOutput out) throws IOException {
             if (provider instanceof Maxmind maxmind) {
                 out.writeString(maxmind.accountId);
             } else {
-                /*
-                 * The existence of a non-Maxmind providers is gated on the feature get_database_configuration_action.multi_node, and
-                 * get_database_configuration_action.multi_node is only available on or after
-                 * TransportVersions.INGEST_GEO_DATABASE_PROVIDERS.
-                 */
                 assert false : "non-maxmind DatabaseConfiguration.Provider [" + provider.getWriteableName() + "]";
             }
         }

modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/direct/TransportGetDatabaseConfigurationAction.java

@@ -17,7 +17,6 @@
 import org.elasticsearch.cluster.service.ClusterService;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.regex.Regex;
-import org.elasticsearch.features.FeatureService;
 import org.elasticsearch.ingest.geoip.DatabaseNodeService;
 import org.elasticsearch.ingest.geoip.GeoIpTaskState;
 import org.elasticsearch.ingest.geoip.IngestGeoIpMetadata;
@@ -41,16 +40,13 @@
 import java.util.Set;
 import java.util.stream.Collectors;
 
-import static org.elasticsearch.ingest.IngestGeoIpFeatures.GET_DATABASE_CONFIGURATION_ACTION_MULTI_NODE;
-
 public class TransportGetDatabaseConfigurationAction extends TransportNodesAction<
     GetDatabaseConfigurationAction.Request,
     GetDatabaseConfigurationAction.Response,
     GetDatabaseConfigurationAction.NodeRequest,
     GetDatabaseConfigurationAction.NodeResponse,
     List<DatabaseConfigurationMetadata>> {
 
-    private final FeatureService featureService;
     private final DatabaseNodeService databaseNodeService;
 
     @Inject
@@ -59,7 +55,6 @@ public TransportGetDatabaseConfigurationAction(
         ClusterService clusterService,
         ThreadPool threadPool,
         ActionFilters actionFilters,
-        FeatureService featureService,
         DatabaseNodeService databaseNodeService
     ) {
         super(
@@ -70,39 +65,9 @@ public TransportGetDatabaseConfigurationAction(
             GetDatabaseConfigurationAction.NodeRequest::new,
             threadPool.executor(ThreadPool.Names.MANAGEMENT)
         );
-        this.featureService = featureService;
         this.databaseNodeService = databaseNodeService;
     }
 
-    @Override
-    protected void doExecute(
-        Task task,
-        GetDatabaseConfigurationAction.Request request,
-        ActionListener<GetDatabaseConfigurationAction.Response> listener
-    ) {
-        if (featureService.clusterHasFeature(clusterService.state(), GET_DATABASE_CONFIGURATION_ACTION_MULTI_NODE) == false) {
-            /*
-             * TransportGetDatabaseConfigurationAction used to be a TransportMasterNodeAction, and not all nodes in the cluster have been
-             * updated. So we don't want to send node requests to the other nodes because they will blow up. Instead, we just return
-             * the information that we used to return from the master node (it doesn't make any difference that this might not be the master
-             * node, because we're only reading the cluster state). Because older nodes only know about the Maxmind provider type, we filter
-             * out all others here to avoid causing problems on those nodes.
-             */
-            newResponseAsync(
-                task,
-                request,
-                createActionContext(task, request).stream()
-                    .filter(database -> database.database().provider() instanceof DatabaseConfiguration.Maxmind)
-                    .toList(),
-                List.of(),
-                List.of(),
-                listener
-            );
-        } else {
-            super.doExecute(task, request, listener);
-        }
-    }
-
     protected List<DatabaseConfigurationMetadata> createActionContext(Task task, GetDatabaseConfigurationAction.Request request) {
         final Set<String> ids;
         if (request.getDatabaseIds().length == 0) {