Skip to content

Commit a3121d4

Browse files
committed
Enabled skippers for scaled_float
1 parent 01be795 commit a3121d4

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

modules/mapper-extras/src/main/java/org/elasticsearch/index/mapper/extras/ScaledFloatFieldMapper.java

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,23 @@ protected Parameter<?>[] getParameters() {
193193
return new Parameter<?>[] { indexed, hasDocValues, stored, ignoreMalformed, meta, scalingFactor, coerce, nullValue, metric };
194194
}
195195

196+
private IndexType indexType() {
197+
if (indexed.getValue()) {
198+
return IndexType.points(true, hasDocValues.getValue());
199+
}
200+
if (hasDocValues.getValue()
201+
&& indexSettings.getIndexVersionCreated().onOrAfter(IndexVersions.STANDARD_INDEXES_USE_SKIPPERS)
202+
&& indexSettings.useDocValuesSkipper()) {
203+
return IndexType.skippers();
204+
}
205+
return IndexType.points(false, hasDocValues.getValue());
206+
}
207+
196208
@Override
197209
public ScaledFloatFieldMapper build(MapperBuilderContext context) {
198-
IndexType indexType = IndexType.points(indexed.get(), hasDocValues.get());
199210
ScaledFloatFieldType type = new ScaledFloatFieldType(
200211
context.buildFullName(leafName()),
201-
indexType,
212+
indexType(),
202213
stored.getValue(),
203214
meta.getValue(),
204215
scalingFactor.getValue(),

modules/mapper-extras/src/test/java/org/elasticsearch/index/mapper/extras/ScaledFloatFieldMapperTests.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -657,9 +657,4 @@ protected List<SortShortcutSupport> getSortShortcutSupport() {
657657
new SortShortcutSupport(this::minimalMapping, this::writeField, false)
658658
);
659659
}
660-
661-
@Override
662-
protected boolean supportsDocValuesSkippers() {
663-
return false;
664-
}
665660
}

test/framework/src/main/java/org/elasticsearch/index/mapper/MapperTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1853,14 +1853,14 @@ protected boolean supportsDocValuesSkippers() {
18531853

18541854
public void testDocValuesSkippers() throws IOException {
18551855
assumeTrue("Mapper does not support doc values skippers", supportsDocValuesSkippers());
1856+
18561857
IndexVersion preSkipperVersion = IndexVersionUtils.randomPreviousCompatibleVersion(
18571858
random(),
18581859
IndexVersions.STANDARD_INDEXES_USE_SKIPPERS
18591860
);
18601861
IndexVersion withSkipperVersion = IndexVersions.STANDARD_INDEXES_USE_SKIPPERS;
18611862

18621863
Settings skippersDisabled = Settings.builder().put(IndexSettings.USE_DOC_VALUES_SKIPPER.getKey(), false).build();
1863-
18641864
Settings skippersEnabled = Settings.builder().put(IndexSettings.USE_DOC_VALUES_SKIPPER.getKey(), true).build();
18651865

18661866
{

0 commit comments

Comments
 (0)