Skip to content

Commit a36e3ae

Browse files
committed
Improve the way test are named.
1 parent 3ae547e commit a36e3ae

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/inference/embedding/DenseEmbeddingOperatorOutputBuilderTests.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package org.elasticsearch.xpack.esql.inference.embedding;
99

10+
import com.carrotsearch.randomizedtesting.annotations.Name;
1011
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
1112

1213
import org.elasticsearch.compute.data.Block;
@@ -36,14 +37,12 @@ public class DenseEmbeddingOperatorOutputBuilderTests extends ComputeTestCase {
3637
TextEmbeddingFloatResults.class
3738
);
3839

39-
private final static String TEST_PARAMS_FORMATING = "dims=%d, input_size=%d, batch_size=%d, embedding_type=%s";
40-
4140
private final int dimensions;
4241
private final int inputPageSize;
4342
private final int batchSize;
4443
private final Class<? extends TextEmbeddingResults<?>> embeddingType;
4544

46-
@ParametersFactory(argumentFormatting = TEST_PARAMS_FORMATING)
45+
@ParametersFactory
4746
public static Iterable<Object[]> parameters() {
4847
List<Object[]> params = new ArrayList<>();
4948
params.add(new Object[] {});
@@ -66,10 +65,10 @@ public static Iterable<Object[]> parameters() {
6665
}
6766

6867
public DenseEmbeddingOperatorOutputBuilderTests(
69-
int dimensions,
70-
int inputPageSize,
71-
int batchSize,
72-
Class<? extends TextEmbeddingBitResults> embeddingType
68+
@Name("dimensions") int dimensions,
69+
@Name("inputPageSize") int inputPageSize,
70+
@Name("batchSize") int batchSize,
71+
@Name("embeddingType") Class<? extends TextEmbeddingBitResults> embeddingType
7372
) {
7473
this.dimensions = dimensions;
7574
this.inputPageSize = inputPageSize;

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/inference/embedding/DenseEmbeddingOperatorTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package org.elasticsearch.xpack.esql.inference.embedding;
99

10+
import com.carrotsearch.randomizedtesting.annotations.Name;
1011
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
1112

1213
import org.apache.lucene.util.BytesRef;
@@ -37,16 +38,14 @@ public class DenseEmbeddingOperatorTests extends InferenceOperatorTestCase<TextE
3738

3839
private static final String SIMPLE_INFERENCE_ID = "test_dense_embedding";
3940

40-
private static final String TEST_PARAMS_FORMATING = "dims=%s, embedding_type=%s";
41-
4241
private static final List<Integer> DIMENSIONS = List.of(1, 32, 128, 512, 2048, 5096);
4342
private static final List<Class<? extends TextEmbeddingResults<?>>> EMBEDDING_TYPES = List.of(
4443
TextEmbeddingBitResults.class,
4544
TextEmbeddingByteResults.class,
4645
TextEmbeddingFloatResults.class
4746
);
4847

49-
@ParametersFactory(argumentFormatting = TEST_PARAMS_FORMATING)
48+
@ParametersFactory
5049
public static Iterable<Object[]> parameters() {
5150
List<Object[]> params = new ArrayList<>();
5251
params.add(new Object[] {});
@@ -71,7 +70,10 @@ public static Iterable<Object[]> parameters() {
7170
private final int dimensions;
7271
private final Class<? extends TextEmbeddingResults<?>> embeddingType;
7372

74-
public DenseEmbeddingOperatorTests(int dimensions, Class<? extends TextEmbeddingResults<?>> embeddingType) {
73+
public DenseEmbeddingOperatorTests(
74+
@Name("dimensions") int dimensions,
75+
@Name("embeddingType") Class<? extends TextEmbeddingResults<?>> embeddingType
76+
) {
7577
this.dimensions = dimensions;
7678
this.embeddingType = embeddingType;
7779
}

0 commit comments

Comments
 (0)