Skip to content

Commit a3dac74

Browse files
authored
TransportVersion for backporting ES|QL sample (#129831)
1 parent e031b3e commit a3dac74

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

server/src/main/java/org/elasticsearch/TransportVersions.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ static TransportVersion def(int id) {
201201
public static final TransportVersion ML_INFERENCE_CUSTOM_SERVICE_EMBEDDING_BATCH_SIZE_8_19 = def(8_841_0_53);
202202
public static final TransportVersion STREAMS_LOGS_SUPPORT_8_19 = def(8_841_0_54);
203203
public static final TransportVersion ML_INFERENCE_CUSTOM_SERVICE_INPUT_TYPE_8_19 = def(8_841_0_55);
204+
public static final TransportVersion RANDOM_SAMPLER_QUERY_BUILDER_8_19 = def(8_841_0_56);
204205

205206
public static final TransportVersion V_9_0_0 = def(9_000_0_09);
206207
public static final TransportVersion INITIAL_ELASTICSEARCH_9_0_1 = def(9_000_0_10);

server/src/main/java/org/elasticsearch/search/aggregations/bucket/sampler/random/RandomSamplingQueryBuilder.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,15 @@ public String getWriteableName() {
139139
return NAME;
140140
}
141141

142-
/**
143-
* The minimal version of the recipient this object can be sent to
144-
*/
142+
@Override
143+
public boolean supportsVersion(TransportVersion version) {
144+
return version.onOrAfter(TransportVersions.RANDOM_SAMPLER_QUERY_BUILDER)
145+
|| version.isPatchFrom(TransportVersions.RANDOM_SAMPLER_QUERY_BUILDER_8_19);
146+
}
147+
145148
@Override
146149
public TransportVersion getMinimalSupportedVersion() {
147-
return TransportVersions.RANDOM_SAMPLER_QUERY_BUILDER;
150+
assert false : "must not be called when overriding supportsVersion";
151+
throw new UnsupportedOperationException("must not be called when overriding supportsVersion");
148152
}
149153
}

0 commit comments

Comments
 (0)