Add tests

Author: carlosdelest

x-pack/plugin/esql/qa/testFixtures/src/main/resources/vector-cosine-similarity.csv-spec

@@ -24,28 +24,28 @@ gainsboro      | 0.908
 gray           | 0.908     
 ;
 
-# TODO Need to implement a conversion function to convert a non-foldable row to a dense_vector
-similarityWithRow-Ignore
-required_capability: cosine_vector_similarity_function
+ similarityAsPartOfExpression
+ required_capability: cosine_vector_similarity_function
 
-row vector = [1, 2, 3] 
-| eval similarity = round(v_cosine(vector, [0, 1, 2]), 3) 
-| sort similarity desc, color asc 
-| limit 10
-| keep color, similarity
-;
+ from colors
+ | where color != "black" 
+ | eval score = round((1 + v_cosine(rgb_vector, [0, 255, 255]) / 2), 3) 
+ | sort score desc, color asc 
+ | limit 10
+ | keep color, score
+ ;
 
-color:text     | similarity:double
-cyan           | 1.0            
-teal           | 1.0            
-turquoise      | 0.989          
-aqua marine    | 0.965          
-azure          | 0.916          
-lavender       | 0.914          
-honeydew       | 0.912          
-mint cream     | 0.912          
-gainsboro      | 0.908          
-gray           | 0.908     
+color:text   | score:double
+cyan         | 1.5
+teal         | 1.5
+turquoise    | 1.495
+aqua marine  | 1.482
+azure        | 1.458
+lavender     | 1.457
+honeydew     | 1.456
+mint cream   | 1.456
+gainsboro    | 1.454
+gray         | 1.454  
 ;
 
 similarityWithLiteralVectors
@@ -56,6 +56,34 @@ row a = 1
 | keep similarity
 ;
 
+similarity:double
+0.978  
+;
+
+ similarityWithStats
+ required_capability: cosine_vector_similarity_function
+ 
+ from colors
+ | where color != "black" 
+ | eval similarity = round(v_cosine(rgb_vector, [0, 255, 255]), 3) 
+ | stats avg = round(avg(similarity), 3), min = min(similarity), max = max(similarity)
+ ;
+
+avg:double | min:double | max:double
+0.832      | 0.5        | 1.0
+;
+
+# TODO Need to implement a conversion function to convert a non-foldable row to a dense_vector
+similarityWithRow-Ignore
+required_capability: cosine_vector_similarity_function
+ 
+row vector = [1, 2, 3] 
+| eval similarity = round(v_cosine(vector, [0, 1, 2]), 3) 
+| sort similarity desc, color asc 
+| limit 10
+| keep color, similarity
+;
+
 similarity:double
 0.978  
 ;

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java

@@ -2413,6 +2413,24 @@ private void checkDenseVectorImplicitCastingSimilarityFunction(String similarity
         assertThat(right.value(), equalTo(List.of(0.342, 0.164, 0.234)));;
     }
 
+    public void testNoDenseVectorFailsSimilarityFunction() {
+        if (EsqlCapabilities.Cap.COSINE_VECTOR_SIMILARITY_FUNCTION.isEnabled()) {
+            checkNoDenseVectorFailsSimilarityFunction("v_cosine([0, 1, 2], 0.342)");
+        }
+    }
+
+    private void checkNoDenseVectorFailsSimilarityFunction(String similarityFunction) {
+        var query = String.format(Locale.ROOT, "row a = 1 |  eval similarity = %s", similarityFunction);
+        VerificationException error = expectThrows(VerificationException.class, () -> analyze(query));
+        assertThat(
+            error.getMessage(),
+            containsString(
+                "second argument of [" + similarityFunction + "] must be"
+                    + " [dense_vector], found value [0.342] type [double]"
+            )
+        );
+    }
+
     public void testRateRequiresCounterTypes() {
         assumeTrue("rate requires snapshot builds", Build.current().isSnapshot());
         Analyzer analyzer = analyzer(tsdbIndexResolution());