Fix InferenceFieldMetadataTest

Author: kderusso

server/src/main/java/org/elasticsearch/cluster/metadata/InferenceFieldMetadata.java

@@ -12,6 +12,7 @@
 import org.elasticsearch.TransportVersions;
 import org.elasticsearch.cluster.Diff;
 import org.elasticsearch.cluster.SimpleDiffable;
+import org.elasticsearch.common.Strings;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.xcontent.ToXContentFragment;
@@ -38,7 +39,8 @@ public final class InferenceFieldMetadata implements SimpleDiffable<InferenceFie
     private static final String INFERENCE_ID_FIELD = "inference_id";
     private static final String SEARCH_INFERENCE_ID_FIELD = "search_inference_id";
     private static final String SOURCE_FIELDS_FIELD = "source_fields";
-    private static final String CHUNKING_SETTINGS_FIELD = "chunking_settings";
+    static final String CHUNKING_SETTINGS_FIELD = "chunking_settings";
+    private final int EXPECTED_CHUNKING_SETTINGS_SIZE = 3;
 
     private final String name;
     private final String inferenceId;
@@ -62,6 +64,10 @@ public InferenceFieldMetadata(
         this.searchInferenceId = Objects.requireNonNull(searchInferenceId);
         this.sourceFields = Objects.requireNonNull(sourceFields);
         this.chunkingSettings = chunkingSettings;
+
+        if (chunkingSettings != null && chunkingSettings.size() != EXPECTED_CHUNKING_SETTINGS_SIZE) {
+            throw new IllegalArgumentException("Chunking settings did not contain expected number of entries, was: " + chunkingSettings);
+        }
     }
 
     public InferenceFieldMetadata(StreamInput input) throws IOException {
@@ -112,6 +118,11 @@ public int hashCode() {
         return result;
     }
 
+    @Override
+    public String toString() {
+        return Strings.toString(this);
+    }
+
     public String getName() {
         return name;
     }
@@ -182,7 +193,6 @@ public static InferenceFieldMetadata fromXContent(XContentParser parser) throws
                 }
             } else if (CHUNKING_SETTINGS_FIELD.equals(currentFieldName)) {
                 chunkingSettings = parser.map();
-
             } else {
                 parser.skipChildren();
             }

server/src/test/java/org/elasticsearch/cluster/metadata/InferenceFieldMetadataTests.java

@@ -38,11 +38,6 @@ protected InferenceFieldMetadata createTestInstance() {
         return createTestItem();
     }
 
-    @Override
-    protected Predicate<String> getRandomFieldsExcludeFilter() {
-        return p -> p.equals(""); // do not add elements at the top-level as any element at this level is parsed as a new inference field
-    }
-
     @Override
     protected InferenceFieldMetadata doParseInstance(XContentParser parser) throws IOException {
         if (parser.nextToken() == XContentParser.Token.START_OBJECT) {
@@ -56,7 +51,7 @@ protected InferenceFieldMetadata doParseInstance(XContentParser parser) throws I
 
     @Override
     protected boolean supportsUnknownFields() {
-        return true;
+        return false;
     }
 
     private static InferenceFieldMetadata createTestItem() {