Addressed review feedback for TimeValue instead of just seconds

Author: schase-es

server/src/main/java/org/elasticsearch/cluster/NodeConnectionsService.java

@@ -402,17 +402,17 @@ public void onNodeConnected(DiscoveryNode node, Transport.Connection connection)
 
             if (disconnectionHistory != null) {
                 long millisSinceDisconnect = threadPool.absoluteTimeInMillis() - disconnectionHistory.disconnectTimeMillis;
-                long secondsSinceDisconnect = millisSinceDisconnect / 1000;
+                TimeValue timeValueSinceDisconnect = TimeValue.timeValueMillis(millisSinceDisconnect);
                 if (disconnectionHistory.disconnectCause != null) {
                     logger.warn(
                         () -> format(
                             """
                                 reopened transport connection to node [%s] \
-                                which disconnected exceptionally [%ds/%dms] ago but did not \
+                                which disconnected exceptionally [%s/%dms] ago but did not \
                                 restart, so the disconnection is unexpected; \
                                 see [%s] for troubleshooting guidance""",
                             node.descriptionWithoutAttributes(),
-                            secondsSinceDisconnect,
+                            timeValueSinceDisconnect,
                             millisSinceDisconnect,
                             ReferenceDocs.NETWORK_DISCONNECT_TROUBLESHOOTING
                         ),
@@ -422,11 +422,11 @@ public void onNodeConnected(DiscoveryNode node, Transport.Connection connection)
                     logger.warn(
                         """
                             reopened transport connection to node [{}] \
-                            which disconnected gracefully [{}s/{}ms] ago but did not \
+                            which disconnected gracefully [{}/{}ms] ago but did not \
                             restart, so the disconnection is unexpected; \
                             see [{}] for troubleshooting guidance""",
                         node.descriptionWithoutAttributes(),
-                        secondsSinceDisconnect,
+                        timeValueSinceDisconnect,
                         millisSinceDisconnect,
                         ReferenceDocs.NETWORK_DISCONNECT_TROUBLESHOOTING
                     );

server/src/test/java/org/elasticsearch/cluster/NodeConnectionsServiceTests.java

@@ -253,7 +253,7 @@ public void testDisconnectionHistory() {
         final DeterministicTaskQueue deterministicTaskQueue = new DeterministicTaskQueue();
         final ThreadPool threadPool = deterministicTaskQueue.getThreadPool();
         final long reconnectIntervalMillis = CLUSTER_NODE_RECONNECT_INTERVAL_SETTING.get(Settings.EMPTY).millis();
-        final long reconnectIntervalSeconds = reconnectIntervalMillis / 1000;
+        final TimeValue reconnectIntervalTimeValue = TimeValue.timeValueMillis(reconnectIntervalMillis);
 
         MockTransport transport = new MockTransport(threadPool);
         TestTransportService transportService = new TestTransportService(transport, threadPool);
@@ -297,8 +297,8 @@ public void testDisconnectionHistory() {
                     "reopened transport connection to node ["
                         + gracefulClose.descriptionWithoutAttributes()
                         + "] which disconnected gracefully ["
-                        + reconnectIntervalSeconds
-                        + "s/"
+                        + reconnectIntervalTimeValue
+                        + "/"
                         + reconnectIntervalMillis
                         + "ms] ago "
                         + "but did not restart, so the disconnection is unexpected; "
@@ -313,8 +313,8 @@ public void testDisconnectionHistory() {
                     "reopened transport connection to node ["
                         + exceptionalClose.descriptionWithoutAttributes()
                         + "] which disconnected exceptionally ["
-                        + reconnectIntervalSeconds
-                        + "s/"
+                        + reconnectIntervalTimeValue
+                        + "/"
                         + reconnectIntervalMillis
                         + "ms] ago "
                         + "but did not restart, so the disconnection is unexpected; "