Preserve integer-exact representation of numbers and allow conversion of floating point values to integers

This differentiates floating point values that are within the range of
exact integer correspondence and renders them as integers rather than
using the default java toString method which formats floating point
values in E-notation when the absolute value is at least 1e6.

The new formatting is used as the input string for the INTEGER and LONG
convert methods enabling conversion from floating point to integer
numbers.

Author: efd6

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/ConvertProcessor.java

@@ -34,7 +34,7 @@ enum Type {
             @Override
             public Object convert(Object value) {
                 try {
-                    String strValue = value.toString();
+                    String strValue = STRING.convert(value);
                     if (strValue.startsWith("0x") || strValue.startsWith("-0x")) {
                         return Integer.decode(strValue);
                     }
@@ -49,7 +49,7 @@ public Object convert(Object value) {
             @Override
             public Object convert(Object value) {
                 try {
-                    String strValue = value.toString();
+                    String strValue = STRING.convert(value);
                     if (strValue.startsWith("0x") || strValue.startsWith("-0x")) {
                         return Long.decode(strValue);
                     }
@@ -102,6 +102,9 @@ public Object convert(Object value) {
         STRING {
             @Override
             public Object convert(Object value) {
+                if (isExactIntegerDouble(value) || isExactIntegerFloat(value)) {
+                    return ((long)value).toString();
+                }
                 return value.toString();
             }
         },
@@ -149,6 +152,24 @@ public static Type fromString(String processorTag, String propertyName, String t
                 );
             }
         }
+
+        private static boolean isExactIntegerFloat(Object value) {
+            final float ABS_MAX_EXACT_FLOAT = 0x1p24-1;
+            if (!(value instanceof Float)) {
+                return false;
+            }
+            float v = ((Float) value).floatValue();
+            return v == (long) v && -ABS_MAX_EXACT_FLOAT <= v && v <= ABS_MAX_EXACT_FLOAT;
+        }
+
+        private static boolean isExactIntegerDouble(Object value) {
+            final double ABS_MAX_EXACT_DOUBLE = 0x1p53-1;
+            if (!(value instanceof Double)) {
+                return false;
+            }
+            double v = ((Double) value).doubleValue();
+            return v == (long) v && -ABS_MAX_EXACT_DOUBLE <= v && v <= ABS_MAX_EXACT_DOUBLE;
+        }
     }
 
     public static final String TYPE = "convert";