some cleanups

Author: romseygeek

server/src/main/java/org/elasticsearch/index/mapper/MappedFieldType.java

@@ -57,7 +57,7 @@ public abstract class MappedFieldType {
 
     private final String name;
     private final boolean docValues;
-    protected final boolean isIndexed;
+    private final boolean isIndexed;
     private final boolean isStored;
     private final TextSearchInfo textSearchInfo;
     private final Map<String, String> meta;
@@ -322,7 +322,7 @@ protected final void failIfNoDocValues() {
         }
     }
 
-    protected void failIfNotIndexed() {
+    protected final void failIfNotIndexed() {
         if (isIndexed == false) {
             // we throw an IAE rather than an ISE so that it translates to a 4xx code rather than 5xx code on the http layer
             throw new IllegalArgumentException("Cannot search on field [" + name() + "] since it is not indexed.");

server/src/main/java/org/elasticsearch/index/mapper/ValueFetcher.java

@@ -8,7 +8,6 @@
 
 package org.elasticsearch.index.mapper;
 
-import org.apache.lucene.index.LeafReaderContext;
 import org.elasticsearch.search.fetch.subphase.FetchFieldsPhase;
 import org.elasticsearch.search.lookup.ValuesLookup;
 

server/src/main/java/org/elasticsearch/search/lookup/ValuesLookup.java

@@ -10,7 +10,6 @@
 
 import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.xcontent.XContentType;
-import org.elasticsearch.index.mapper.MappedFieldType;
 import org.elasticsearch.search.DocValueFormat;
 
 import java.util.List;
@@ -28,7 +27,7 @@ public interface ValuesLookup {
     SourceLookup source();
 
     /**
-     * Returns a LeafDocLookup positioned on the current document
+     * Returns a list of formatted doc values for a given field on the current document
      */
     List<Object> docValues(String field, DocValueFormat format);