Fixing DataStream::getEffectiveSettings for component templates (#127515)

Author: masseyke

modules/data-streams/src/test/java/org/elasticsearch/datastreams/action/TransportGetDataStreamsActionTests.java

@@ -11,6 +11,7 @@
 import org.elasticsearch.action.datastreams.GetDataStreamAction;
 import org.elasticsearch.cluster.ClusterName;
 import org.elasticsearch.cluster.ClusterState;
+import org.elasticsearch.cluster.metadata.ComponentTemplate;
 import org.elasticsearch.cluster.metadata.ComposableIndexTemplate;
 import org.elasticsearch.cluster.metadata.DataStream;
 import org.elasticsearch.cluster.metadata.DataStreamFailureStoreSettings;
@@ -38,6 +39,7 @@
 import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -548,10 +550,41 @@ public void testGetEffectiveSettingsTemplateOnlySettings() {
         GetDataStreamAction.Request req = new GetDataStreamAction.Request(TEST_REQUEST_TIMEOUT, new String[] {});
         final String templatePolicy = "templatePolicy";
         final String templateIndexMode = IndexMode.LOOKUP.getName();
-        final String dataStreamPolicy = "dataStreamPolicy";
-        final String dataStreamIndexMode = IndexMode.LOGSDB.getName();
 
         ClusterState state = getClusterStateWithDataStreamWithSettings(
+            Settings.builder()
+                .put(IndexMetadata.LIFECYCLE_NAME, templatePolicy)
+                .put(IndexSettings.MODE.getKey(), templateIndexMode)
+                .build(),
+            Settings.EMPTY,
+            Settings.EMPTY
+        );
+
+        GetDataStreamAction.Response response = TransportGetDataStreamsAction.innerOperation(
+            state,
+            req,
+            resolver,
+            systemIndices,
+            ClusterSettings.createBuiltInClusterSettings(),
+            dataStreamGlobalRetentionSettings,
+            emptyDataStreamFailureStoreSettings,
+            new IndexSettingProviders(Set.of()),
+            null
+        );
+        assertNotNull(response.getDataStreams());
+        assertThat(response.getDataStreams().size(), equalTo(1));
+        assertThat(response.getDataStreams().get(0).getIlmPolicy(), equalTo(templatePolicy));
+        assertThat(response.getDataStreams().get(0).getIndexModeName(), equalTo(templateIndexMode));
+    }
+
+    public void testGetEffectiveSettingsComponentTemplateOnlySettings() {
+        // Set a lifecycle only in the template, and make sure that is in the response:
+        GetDataStreamAction.Request req = new GetDataStreamAction.Request(TEST_REQUEST_TIMEOUT, new String[] {});
+        final String templatePolicy = "templatePolicy";
+        final String templateIndexMode = IndexMode.LOOKUP.getName();
+
+        ClusterState state = getClusterStateWithDataStreamWithSettings(
+            Settings.EMPTY,
             Settings.builder()
                 .put(IndexMetadata.LIFECYCLE_NAME, templatePolicy)
                 .put(IndexSettings.MODE.getKey(), templateIndexMode)
@@ -584,6 +617,10 @@ public void testGetEffectiveSettings() {
         final String dataStreamIndexMode = IndexMode.LOGSDB.getName();
         // Now set a lifecycle in both the template and the data stream, and make sure the response has the data stream one:
         ClusterState state = getClusterStateWithDataStreamWithSettings(
+            Settings.builder()
+                .put(IndexMetadata.LIFECYCLE_NAME, templatePolicy)
+                .put(IndexSettings.MODE.getKey(), templateIndexMode)
+                .build(),
             Settings.builder()
                 .put(IndexMetadata.LIFECYCLE_NAME, templatePolicy)
                 .put(IndexSettings.MODE.getKey(), templateIndexMode)
@@ -610,7 +647,11 @@ public void testGetEffectiveSettings() {
         assertThat(response.getDataStreams().get(0).getIndexModeName(), equalTo(dataStreamIndexMode));
     }
 
-    private static ClusterState getClusterStateWithDataStreamWithSettings(Settings templateSettings, Settings dataStreamSettings) {
+    private static ClusterState getClusterStateWithDataStreamWithSettings(
+        Settings templateSettings,
+        Settings componentTemplateSettings,
+        Settings dataStreamSettings
+    ) {
         String dataStreamName = "data-stream-1";
         int numberOfBackingIndices = randomIntBetween(1, 5);
         long currentTime = System.currentTimeMillis();
@@ -623,8 +664,16 @@ private static ClusterState getClusterStateWithDataStreamWithSettings(Settings t
                 .indexPatterns(List.of("*"))
                 .template(Template.builder().settings(templateSettings))
                 .dataStreamTemplate(new ComposableIndexTemplate.DataStreamTemplate())
+                .componentTemplates(List.of("component_template_1"))
                 .build()
         );
+        ComponentTemplate componentTemplate = new ComponentTemplate(
+            Template.builder().settings(componentTemplateSettings).build(),
+            null,
+            null,
+            null
+        );
+        builder.componentTemplates(Map.of("component_template_1", componentTemplate));
 
         List<IndexMetadata> backingIndices = new ArrayList<>();
         for (int backingIndexNumber = 1; backingIndexNumber <= numberOfBackingIndices; backingIndexNumber++) {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java

@@ -376,12 +376,7 @@ public ComposableIndexTemplate getEffectiveIndexTemplate(Metadata metadata) {
 
     public Settings getEffectiveSettings(Metadata metadata) {
         ComposableIndexTemplate template = getMatchingIndexTemplate(metadata);
-        final Settings templateSettings;
-        if (template.template() == null || template.template().settings() == null) {
-            templateSettings = Settings.EMPTY;
-        } else {
-            templateSettings = template.template().settings();
-        }
+        Settings templateSettings = MetadataIndexTemplateService.resolveSettings(template, metadata.componentTemplates());
         return templateSettings.merge(settings);
     }
 

server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamTests.java

@@ -2444,6 +2444,26 @@ public void testGetEffectiveSettingsTemplateSettingsOnly() {
         assertThat(dataStream.getEffectiveSettings(metadataBuilder.build()), equalTo(templateSettings));
     }
 
+    public void testGetEffectiveSettingsComponentTemplateSettingsOnly() {
+        // We only have settings from a component template, so we expect to get those back
+        DataStream dataStream = createDataStream(Settings.EMPTY);
+        Settings templateSettings = Settings.EMPTY;
+        Template.Builder indexTemplateBuilder = Template.builder().settings(templateSettings);
+        ComposableIndexTemplate indexTemplate = ComposableIndexTemplate.builder()
+            .indexPatterns(List.of(dataStream.getName()))
+            .dataStreamTemplate(new ComposableIndexTemplate.DataStreamTemplate())
+            .template(indexTemplateBuilder)
+            .componentTemplates(List.of("component-template-1"))
+            .build();
+        Settings componentSettings = randomSettings();
+        Template.Builder componentTemplateBuilder = Template.builder().settings(componentSettings);
+        ComponentTemplate componentTemplate1 = new ComponentTemplate(componentTemplateBuilder.build(), null, null, null);
+        Metadata.Builder projectMetadataBuilder = Metadata.builder()
+            .indexTemplates(Map.of(dataStream.getName(), indexTemplate))
+            .componentTemplates(Map.of("component-template-1", componentTemplate1));
+        assertThat(dataStream.getEffectiveSettings(projectMetadataBuilder.build()), equalTo(componentSettings));
+    }
+
     public void testGetEffectiveSettingsDataStreamSettingsOnly() {
         // We only have settings from the data stream, so we expect to get those back
         Settings dataStreamSettings = randomSettings();