fix lint issues

Author: Samiul-TheSoccerFan

server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java

@@ -363,22 +363,21 @@ public Builder indexOptions(IndexOptions indexOptions) {
 
         @Override
         public DenseVectorFieldMapper build(MapperBuilderContext context) {
-            DenseVectorFieldType denseVectorFieldType = new DenseVectorFieldType(
-                context.buildFullName(leafName()),
-                indexVersionCreated,
-                elementType.getValue(),
-                dims.getValue(),
-                indexed.getValue(),
-                similarity.getValue(),
-                indexOptions.getValue(),
-                meta.getValue()
-            );
             // Validate again here because the dimensions or element type could have been set programmatically,
             // which affects index option validity
             validate();
             return new DenseVectorFieldMapper(
                 leafName(),
-                denseVectorFieldType,
+                new DenseVectorFieldType(
+                    context.buildFullName(leafName()),
+                    indexVersionCreated,
+                    elementType.getValue(),
+                    dims.getValue(),
+                    indexed.getValue(),
+                    similarity.getValue(),
+                    indexOptions.getValue(),
+                    meta.getValue()
+                ),
                 builderParams(this, context),
                 indexOptions.getValue(),
                 indexVersionCreated

server/src/main/java/org/elasticsearch/index/mapper/vectors/SparseVectorFieldMapper.java

@@ -90,12 +90,11 @@ protected Parameter<?>[] getParameters() {
 
         @Override
         public SparseVectorFieldMapper build(MapperBuilderContext context) {
-            SparseVectorFieldType sparseVectorFieldType = new SparseVectorFieldType(
-                context.buildFullName(leafName()),
-                stored.getValue(),
-                meta.getValue()
+            return new SparseVectorFieldMapper(
+                leafName(),
+                new SparseVectorFieldType(context.buildFullName(leafName()), stored.getValue(), meta.getValue()),
+                builderParams(this, context)
             );
-            return new SparseVectorFieldMapper(leafName(), sparseVectorFieldType, builderParams(this, context));
         }
     }
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/OffsetSourceFieldMapper.java

@@ -119,9 +119,11 @@ protected Parameter<?>[] getParameters() {
 
         @Override
         public OffsetSourceFieldMapper build(MapperBuilderContext context) {
-            OffsetSourceFieldType fieldType = new OffsetSourceFieldType(context.buildFullName(leafName()), charset.get(), meta.getValue());
-
-            return new OffsetSourceFieldMapper(leafName(), fieldType, builderParams(this, context));
+            return new OffsetSourceFieldMapper(
+                leafName(),
+                new OffsetSourceFieldType(context.buildFullName(leafName()), charset.get(), meta.getValue()),
+                builderParams(this, context)
+            );
         }
     }