Fix: Include script params in BulkRequest size calculation

The BulkRequest's size calculation in internalAdd(UpdateRequest) method
currently doesn't account for the size of script parameters. This can lead
to underestimating the actual request size when script parameters are used.

Added script parameters size calculation using script.getParams().toString().length()

Author: mbohm-atl

server/src/main/java/org/elasticsearch/action/bulk/BulkRequest.java

@@ -35,6 +35,7 @@
 import org.elasticsearch.core.RestApiVersion;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.index.shard.ShardId;
+import org.elasticsearch.script.Script;
 import org.elasticsearch.search.fetch.subphase.FetchSourceContext;
 import org.elasticsearch.transport.RawIndexingDataTransportRequest;
 import org.elasticsearch.xcontent.XContentType;
@@ -195,8 +196,10 @@ BulkRequest internalAdd(UpdateRequest request) {
         if (request.upsertRequest() != null) {
             sizeInBytes += request.upsertRequest().source().length();
         }
-        if (request.script() != null) {
-            sizeInBytes += request.script().getIdOrCode().length() * 2;
+        Script script = request.script();
+        if (script != null) {
+            sizeInBytes += (long) script.getIdOrCode().length() * 2L;
+            sizeInBytes += script.getParams().toString().length();
         }
         indices.add(request.index());
         return this;

server/src/test/java/org/elasticsearch/action/bulk/BulkRequestTests.java

@@ -22,6 +22,7 @@
 import org.elasticsearch.common.io.stream.BytesStreamOutput;
 import org.elasticsearch.common.xcontent.XContentHelper;
 import org.elasticsearch.script.Script;
+import org.elasticsearch.script.ScriptType;
 import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.xcontent.XContentBuilder;
 import org.elasticsearch.xcontent.XContentFactory;
@@ -30,6 +31,7 @@
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -40,6 +42,8 @@
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.empty;
 import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.greaterThan;
+import static org.hamcrest.Matchers.greaterThanOrEqualTo;
 import static org.hamcrest.Matchers.hasSize;
 import static org.hamcrest.Matchers.instanceOf;
 import static org.hamcrest.Matchers.is;
@@ -496,4 +500,27 @@ public void testShallowClone() {
         assertThat(shallowCopy.requireAlias(), equalTo(bulkRequest.requireAlias()));
         assertThat(shallowCopy.requireDataStream(), equalTo(bulkRequest.requireDataStream()));
     }
+
+    public void testScriptParamsAreIncludedInSize() {
+        BulkRequest bulkRequest = new BulkRequest();
+
+        UpdateRequest requestWithEmptyParams = new UpdateRequest("index", "id1");
+        requestWithEmptyParams.script(
+            new Script(ScriptType.INLINE, Script.DEFAULT_SCRIPT_LANG, "test script", Collections.emptyMap())
+        );
+        bulkRequest.add(requestWithEmptyParams);
+        long sizeWithEmptyParams = bulkRequest.estimatedSizeInBytes();
+
+        UpdateRequest requestWithParams = new UpdateRequest("index", "id2");
+        Map<String, Object> params = new HashMap<>();
+        params.put("param1", "test_value");
+        requestWithParams.script(
+            new Script(ScriptType.INLINE, Script.DEFAULT_SCRIPT_LANG, "test script", params)
+        );
+        bulkRequest.add(requestWithParams);
+        long sizeWithParams = bulkRequest.estimatedSizeInBytes();
+
+        assertThat(sizeWithParams, greaterThan(sizeWithEmptyParams));
+        assertThat(sizeWithParams - sizeWithEmptyParams, greaterThanOrEqualTo((long) params.toString().length()));
+    }
 }