Missed a sqrt

thecoop · thecoop · commit a737c34092ff · 2025-02-27T17:13:49.000Z
diff --git a/server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java b/server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java
@@ -83,6 +83,7 @@ public ByteDenseVectorFunction(
                         for (float val : floatQueryVector) {
                             queryMagnitude += val * val;
                         }
+                        queryMagnitude = Math.sqrt(queryMagnitude);
                         for (int i = 0; i < floatQueryVector.length; i++) {
                             floatQueryVector[i] /= (float) queryMagnitude;
                         }

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,7 @@ public ByteDenseVectorFunction(`
`83`	`83`	`for (float val : floatQueryVector) {`
`84`	`84`	`queryMagnitude += val * val;`
`85`	`85`	`}`
	`86`	`+ queryMagnitude = Math.sqrt(queryMagnitude);`
`86`	`87`	`for (int i = 0; i < floatQueryVector.length; i++) {`
`87`	`88`	`floatQueryVector[i] /= (float) queryMagnitude;`
`88`	`89`	`}`