Commit a977c95
authored
Increase local breaker reserve memory (#133770)
Currently, we use a local breaker that over-reserves memory for each
driver to reduce frequent calls to the global circuit breaker, which can
be expensive. After reviewing some profiles, the maximum reserved
amount appears too small and does not significantly reduce calls to the
global breaker.
The reserved amount should cover at least several pages of data (~256KB
by default). This change proposes increasing the maximum reserved to two
pages (512KB). One downside is that we may hit the circuit breaker
earlier under extremely tight memory conditions, but the impact should
be minimal. For example, on a node with 8 CPUs, the total reserved could
be 12 * 0.5 = 6MB. In cases with many long-running queries that
frequently wake and sleep, the extra over-reserved memory may be more
noticeable. However, even with 100 drivers, the total maximum would be
only 50MB.1 parent 733d841 commit a977c95
File tree
1 file changed
+2
-2
lines changed- x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
0 commit comments