Fix bug introduced while moving to all shared args

Author: parkertimmins

x-pack/plugin/mapper-patterned-text/src/main/java/org/elasticsearch/xpack/patternedtext/PatternedTextDocValues.java

@@ -36,9 +36,6 @@ static PatternedTextDocValues from(LeafReader leafReader, String templateFieldNa
         }
 
         SortedSetDocValues argsDocValues = DocValues.getSortedSet(leafReader, argsFieldName);
-
-        assert templateDocValues.getValueCount() <= 1;
-        assert argsDocValues.getValueCount() <= 1;
         return new PatternedTextDocValues(templateDocValues, argsDocValues);
     }
 
@@ -61,7 +58,10 @@ String lookupOrdAsString(long l) throws IOException {
         String template = templateDocValues.lookupOrd(l).utf8ToString();
         int argsCount = PatternedTextValueProcessor.countArgs(template);
         List<String> args = new ArrayList<>(argsCount);
-        PatternedTextValueProcessor.addRemainingArgs(args, argsDocValues.lookupOrd(argsDocValues.nextOrd()).utf8ToString());
+        if (argsCount > 0) {
+            var mergedArgs = argsDocValues.lookupOrd(argsDocValues.nextOrd());
+            PatternedTextValueProcessor.addRemainingArgs(args, mergedArgs.utf8ToString());
+        }
         return PatternedTextValueProcessor.merge(new PatternedTextValueProcessor.Parts(template, args, null));
     }
 

x-pack/plugin/mapper-patterned-text/src/main/java/org/elasticsearch/xpack/patternedtext/PatternedTextValueProcessor.java

@@ -17,16 +17,6 @@ public class PatternedTextValueProcessor {
     private static final String SPACE = " ";
 
     record Parts(String template, List<String> args, String indexed) {
-        String templateStripped() {
-            List<String> stripped = new ArrayList<>();
-            String[] parts = template.split(SPACE);
-            for (String part : parts) {
-                if (part.startsWith("%") == false) {
-                    stripped.add(part);
-                }
-            }
-            return String.join(SPACE, stripped);
-        }
     }
 
     static Parts split(String text) {