iter

Author: john-wagster

server/src/test/java/org/elasticsearch/search/vectors/KnnSearchBuilderTests.java

@@ -113,7 +113,7 @@ protected KnnSearchBuilder createTestInstance() {
 
     @Override
     protected KnnSearchBuilder mutateInstance(KnnSearchBuilder instance) {
-        return switch (random().nextInt(9)) {
+        return switch (IVF_FORMAT.isEnabled() ? random().nextInt(9) : random().nextInt(8)) {
             case 0 -> {
                 String newField = randomValueOtherThan(instance.field, () -> randomAlphaOfLength(5));
                 yield new KnnSearchBuilder(

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/KnnSemanticTextTestCase.java

@@ -37,11 +37,13 @@ public class KnnSemanticTextTestCase extends ESRestTestCase {
 
     @Before
     public void checkCapability() {
-        assumeTrue("knn with semantic text not available", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
+        // TODO: not sure why this doesn't work??
+        // assumeTrue("knn with semantic text not available", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
     }
 
     @SuppressWarnings("unchecked")
     public void testKnnQueryWithSemanticText() throws IOException {
+        assumeTrue("knn with semantic text not available", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
         String knnQuery = """
             FROM semantic-test METADATA _score
             | WHERE knn(dense_semantic, [0, 1, 2])
@@ -63,6 +65,7 @@ public void testKnnQueryWithSemanticText() throws IOException {
     }
 
     public void testKnnQueryOnTextField() throws IOException {
+        assumeTrue("knn with semantic text not available", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
         String knnQuery = """
             FROM semantic-test METADATA _score
             | WHERE knn(text, [0, 1, 2])
@@ -77,6 +80,7 @@ public void testKnnQueryOnTextField() throws IOException {
     }
 
     public void testKnnQueryOnSparseSemanticTextField() throws IOException {
+        assumeTrue("knn with semantic text not available", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
         String knnQuery = """
             FROM semantic-test METADATA _score
             | WHERE knn(sparse_semantic, [0, 1, 2])