clean up logging some more

Author: not-napoleon

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java

@@ -551,7 +551,7 @@ public enum Cap {
          */
         DATE_NANOS_DATE_DIFF(),
         /**
-         * Indicates that https://github.com/elastic/elasticsearch/issues/125439 is fixed
+         * Indicates that https://github.com/elastic/elasticsearch/issues/125439 (incorrect lucene push down for date nanos) is fixed
          */
         FIX_DATE_NANOS_LUCENE_PUSHDOWN_BUG(),
         /**

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/Range.java

@@ -218,7 +218,10 @@ private RangeQuery translate(TranslatorHandler handler) {
 
         DataType dataType = value.dataType();
         logger.trace(
-            "Translating Range into lucene query.  dataType is [" + dataType + "] upper is [" + upper + "]  lower is [" + lower + "]"
+                "Translating Range into lucene query.  dataType is [{}] upper is [{}]  lower is [{}]",
+                dataType,
+                lower,
+                upper
         );
         if (dataType == DataType.DATETIME && lower.dataType() == DATETIME && upper.dataType() == DATETIME) {
             l = dateTimeToString((Long) l);

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/comparison/EsqlBinaryComparison.java

@@ -383,19 +383,13 @@ private Query translate(TranslatorHandler handler) {
         boolean isDateLiteralComparison = false;
 
         logger.trace(
-            "Translating binary comparison with right: ["
-                + right()
-                + "<"
-                + right().dataType()
-                + ">] left: ["
-                + left()
-                + "<"
-                + left().dataType()
-                + ">] attribute: ["
-                + attribute
-                + "<"
-                + attribute.dataType()
-                + ">]"
+            "Translating binary comparison with right: [{}<{}>], left: [{}<{}>], attribute: [{}<{}>]",
+                 right(),
+                 right().dataType(),
+                 left(),
+                 left().dataType(),
+                 attribute,
+                 attribute.dataType()
         );
 
         // TODO: This type coersion layer is copied directly from the QL counterpart code. It's probably not necessary or desireable

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/EsPhysicalOperationProviders.java

@@ -184,7 +184,7 @@ public Function<org.elasticsearch.compute.lucene.ShardContext, Query> querySuppl
     @Override
     public final PhysicalOperation sourcePhysicalOperation(EsQueryExec esQueryExec, LocalExecutionPlannerContext context) {
         final LuceneOperator.Factory luceneFactory;
-        logger.trace("Query Exec is " + esQueryExec);
+        logger.trace("Query Exec is {}", esQueryExec);
 
         List<Sort> sorts = esQueryExec.sorts();
         assert esQueryExec.estimatedRowSize() != null : "estimated row size not initialized";