Skip to content

Commit ab11958

Browse files
committed
wip fixes
1 parent 62e4d0c commit ab11958

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

server/src/main/java/org/elasticsearch/search/vectors/AbstractIVFKnnVectorQuery.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {
141141
// TODO : are these magic numbers ?
142142
double cutoff_affinity = 0.01; // minimum affinity score for a segment to be considered
143143
double higher_affinity = 0.6; // min affinity for increasing nProbe
144-
double lower_affinity = 0.59; // max affinity for decreasing nProbe
144+
double lower_affinity = 0.6; // max affinity for decreasing nProbe
145145
int max_adjustment = 20;
146146

147147
Map<LeafReaderContext, Integer> segmentNProbeMap = new HashMap<>();
@@ -261,9 +261,10 @@ private List<SegmentAffinity> calculateSegmentAffinities(List<LeafReaderContext>
261261
}
262262
}
263263

264-
// sort segments by affinity score in descending order
265-
segmentAffinities.sort((a, b) -> Double.compare(b.affinityScore(), a.affinityScore()));
266-
return segmentAffinities.subList(0, (int) (segmentAffinities.size() * 0.95));
264+
// TODO: sort segments by affinity score in descending order, and cut the long tail ?
265+
//segmentAffinities.sort((a, b) -> Double.compare(b.affinityScore(), a.affinityScore()));
266+
//...subList(0, (int) (segmentAffinities.size() * 0.99));
267+
return segmentAffinities;
267268
}
268269

269270
private record SegmentAffinity(LeafReaderContext context, double affinityScore) {}

0 commit comments

Comments
 (0)