Skip to content

Commit acd1941

Browse files
authored
Change severity of negative stats messages from WARN to DEBUG (#60375) (#81813)
1 parent e3f725f commit acd1941

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

server/src/main/java/org/elasticsearch/monitor/os/OsProbe.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public long getFreePhysicalMemorySize() {
9292
try {
9393
final long freeMem = (long) getFreePhysicalMemorySize.invoke(osMxBean);
9494
if (freeMem < 0) {
95-
logger.warn("OS reported a negative free memory value [{}]", freeMem);
95+
logger.debug("OS reported a negative free memory value [{}]", freeMem);
9696
return 0;
9797
}
9898
return freeMem;
@@ -113,7 +113,7 @@ public long getTotalPhysicalMemorySize() {
113113
try {
114114
final long totalMem = (long) getTotalPhysicalMemorySize.invoke(osMxBean);
115115
if (totalMem < 0) {
116-
logger.warn("OS reported a negative total memory value [{}]", totalMem);
116+
logger.debug("OS reported a negative total memory value [{}]", totalMem);
117117
return 0;
118118
}
119119
return totalMem;
@@ -134,7 +134,7 @@ public long getFreeSwapSpaceSize() {
134134
try {
135135
final long mem = (long) getFreeSwapSpaceSize.invoke(osMxBean);
136136
if (mem < 0) {
137-
logger.warn("OS reported a negative free swap space size [{}]", mem);
137+
logger.debug("OS reported a negative free swap space size [{}]", mem);
138138
return 0;
139139
}
140140
return mem;
@@ -155,7 +155,7 @@ public long getTotalSwapSpaceSize() {
155155
try {
156156
final long mem = (long) getTotalSwapSpaceSize.invoke(osMxBean);
157157
if (mem < 0) {
158-
logger.warn("OS reported a negative total swap space size [{}]", mem);
158+
logger.debug("OS reported a negative total swap space size [{}]", mem);
159159
return 0;
160160
}
161161
return mem;

server/src/main/java/org/elasticsearch/monitor/os/OsStats.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,9 @@ public ByteSizeValue getUsed() {
236236
//
237237
// We intentionally check for (total == 0) rather than (total - free < 0) so as not to hide
238238
// cases where (free > total) which would be a different bug.
239-
logger.warn("cannot compute used swap when total swap is 0 and free swap is " + free);
239+
if (free > 0) {
240+
logger.debug("cannot compute used swap when total swap is 0 and free swap is " + free);
241+
}
240242
return new ByteSizeValue(0);
241243
}
242244
return new ByteSizeValue(total - free);
@@ -304,7 +306,9 @@ public ByteSizeValue getUsed() {
304306
//
305307
// We intentionally check for (total == 0) rather than (total - free < 0) so as not to hide
306308
// cases where (free > total) which would be a different bug.
307-
logger.warn("cannot compute used memory when total memory is 0 and free memory is " + free);
309+
if (free > 0) {
310+
logger.debug("cannot compute used memory when total memory is 0 and free memory is " + free);
311+
}
308312
return new ByteSizeValue(0);
309313
}
310314
return new ByteSizeValue(total - free);

0 commit comments

Comments
 (0)